Incorrect type settings for videorecorder



constructor(engine: Engine, options?: Nullable<VideoRecorderOptions>);

VideoRecorderOptions should be marked as Partial, not Nullable to allow to pass only some options. Besides, its already optional parameter so Nullable makes no sense

When VideoRecorderOptions is passed we have 3 required parameters and one optional one, if this was changed to Partial then all parameters would be optional. It would still work since we have a default, but I’m not sure if this would be desired behavior. @sebavan what do you think?

exactly - for example, its common to change fps, but why would i change mimeType from defaults or touch chunkSize when i don’t even know what it does exactly.

Will be fixed by Allow partial options in videorecorder. by sebavan · Pull Request #12083 · BabylonJS/Babylon.js · GitHub