I didn’t even realize we have the AreClose function. feels very abstract in nature
I also can’t find any usage of this function anywhere in the framework.
I think your function makes a lot more sense. I need to think if changing the signature makes sense, though it is a breaking change.
Sure, and you are totally right.
but the AreClose function makes little sense to me. How do we define close?. So it either needs to be better documented or change in a way that makes more sense. For example, something like what you do, with an extra default epsilon:
Adding a new default parameter is not a breaking change, and i’ll be happy to approve it
As long as it still returns boolean and can be used with the same syntax as before it isn’t. I thought of changing the return type, but if we still return boolean with delta/epsilon/whatever-the-right-term-is there is no need for that.