I'm trying to make BabylonReactNative to work on macOS

bghgary · May 15, 2023, 7:49pm

Noop is no operation, meaning it is a stub renderer that will do nothing. You need to figure out why bgfx ended up here. Sometimes this is because bgfx ended up in a bad state and switched the type to the noop renderer to prevent additional errors.

jihoobyeon · May 16, 2023, 12:53pm

OK, Now I found malfunctioning point:

I added std::cout << "Score: " << ii << ", Type: " << renderer << ", Null? " << (renderCtx == NULL ? 0 : 1) << std::endl; after this line, and result was:

Score: 0, Type: 6, Null? 0
Score: 1, Type: 0, Null? 1

I assume that it should had to be:

Score: 0, Type: 0, Null? 0
Score: 1, Type: 6, Null? 1

but some reason type enum value has mixed up - eventually calling RendererContextNoop instead of RendererContextMtl.

jihoobyeon · May 17, 2023, 12:32pm

I tried to force-render by changing !!BGFX_CONFIG_RENDERER_METAL to true, but m_encoder crashes when frameNum is gonna hit 4. (until 3 it runs)
Any suspects?

bghgary · May 17, 2023, 8:28pm

I’m not sure. Are you able to capture with the metal debugger? Are there any errors in the output?

jihoobyeon · May 18, 2023, 1:48am

Sadly, Xcode does not enables capturing in this case.
something odd is frameNum has logged until 3, but left side of Xcode it says 1.
I tried to continue at console’s (lldb), the red line has changed to green, but still stuck on there.

jihoobyeon · May 18, 2023, 4:44am

I found that s_renderMtl in mtl::rendererCreate has made, but does not have s_renderMtl->init(_init), thus returning NULL.
I tried to force return s_renderMtl even it does not have init(_init), but it fell into infinite loop.

Any suspects?

bghgary · May 18, 2023, 3:03pm

I’m not sure I can be much help. You are knee deep in bgfx now and it is a matter of debugging to see what is wrong. If I can find some time, I’ll try to repro, but it might be a while before I can do it.

jihoobyeon · May 21, 2023, 11:30am

Feel free to do when you have some time.
Since I’m still undergraduate senior, thus I have more time than you, I’ll try deeper.

I’ve now found that g_platformData.nwh always returns 0x0, makes m_metalLayer NULL.
but cannot find where g_platformData is being initialized. still finding the point…

Cedric · May 22, 2023, 8:06am

It looks like there is no Metal device available. Are you running the app on a Metal enabled Mac? Or some virtualization that would set Metal as unavailable?

jihoobyeon · May 23, 2023, 11:20am

I’m using physical device - 2020 M1 Mac mini with macOS Ventura and I can see Metal GPU Frame Capture Enabled and Metal API Validation Enabled on logs.
Should I have to manually enable Metal? Internet says it is enabled by default on macOS.

jihoobyeon · May 23, 2023, 11:27am

Oh, I found almost same case.
He or she said “It works fine when i set PlatformData with metal context and layer(render to screen).”

How can I manually get Metal context and layer so I can set them to g_platformData?

Cedric · May 23, 2023, 12:00pm

You can get everything from the view, get the metal layer from that.
I don’t have everything in mind but I remember the Apple documentation was very good for that.

jihoobyeon · May 24, 2023, 12:55pm

Hmm, I tried a while but no luck.

I added g_platformData.nwh = [NSApplication sharedApplication].mainWindow.contentView; and got this:

-[MTLDebugDevice newBufferWithBytes:length:options:]:666: failed assertion `Buffer Validation
Cannot create buffer of zero length.
newBufferWithBytes:pointer must not be nil.

seems to be banged on here, so I tried many things on there, but nothing changes anything.

Maybe the line I added is wrong.
but nwh is window handle, so I think that line should work…

jihoobyeon · May 26, 2023, 9:38am

I found that mem->size is always 0, resulting to crash in here.
I tried while (mem == nullptr || mem->size == 0) _cmdbuf.read(mem), but it always crashes on mem->size == 0 part.
Maybe there’s no size on mem - which case we didn’t expect.

Any suspects?

Cedric · May 26, 2023, 12:34pm

Are you trying to load a .gltf? Do you have a complete callstack?

jihoobyeon · May 27, 2023, 10:49am

Not loading .gltf, just testing with MeshBuilder.CreateSphere only.
And here is my call stack:

#0	0x0000000100abcf58 in bgfx::mtl::RendererContextMtl::updateDynamicIndexBuffer(bgfx::IndexBufferHandle, unsigned int, unsigned int, bgfx::Memory const*) at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Dependencies/bgfx.cmake/bgfx/src/renderer_mtl.mm:943
#1	0x0000000100a8a434 in bgfx::Context::rendererExecCommands(bgfx::CommandBuffer&) at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Dependencies/bgfx.cmake/bgfx/src/bgfx.cpp:2979
#2	0x0000000100a85a38 in bgfx::Context::renderFrame(int) at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Dependencies/bgfx.cmake/bgfx/src/bgfx.cpp:2448
#3	0x0000000100a895e4 in bgfx::Context::swap() at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Dependencies/bgfx.cmake/bgfx/src/bgfx.cpp:2365
#4	0x0000000100a87488 in bgfx::Context::frameNoRenderWait() at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Dependencies/bgfx.cmake/bgfx/src/bgfx.cpp:2330
#5	0x0000000100a869d4 in bgfx::Context::init(bgfx::Init const&) at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Dependencies/bgfx.cmake/bgfx/src/bgfx.cpp:1972
#6	0x0000000100a8c8fc in bgfx::init(bgfx::Init const&) at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Dependencies/bgfx.cmake/bgfx/src/bgfx.cpp:3554
#7	0x00000001002af3b0 in Babylon::Graphics::DeviceImpl::EnableRendering() at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Core/Graphics/Source/DeviceImpl.cpp:160
#8	0x00000001002a32c8 in Babylon::Graphics::Device::EnableRendering() at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native-macos/submodules/BabylonNative/Core/Graphics/Source/Device.cpp:75
#9	0x00000001001bc360 in BabylonNative::ReactNativeModule::UpdateGraphicsConfiguration() at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native/shared/BabylonNative.cpp:96
#10	0x00000001001bbab0 in BabylonNative::ReactNativeModule::RenderView() at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native/shared/BabylonNative.cpp:140
#11	0x00000001001bba48 in BabylonNative::RenderView() at /Users/jihoobyeon/Desktop/BabylonReactNative/Modules/@babylonjs/react-native/shared/BabylonNative.cpp:325
#12	0x0000000100bc3108 in +[BabylonNativeInterop renderView] at /Users/jihoobyeon/Desktop/foo/node_modules/@babylonjs/react-native-macos-arm64/macos/BabylonNativeInterop.mm:71
#13	0x0000000100bc6f80 in -[EngineView drawRect:] at /Users/jihoobyeon/Desktop/foo/node_modules/@babylonjs/react-native-macos-arm64/macos/EngineViewManager.mm:47
#14	0x00000001994c4c70 in -[MTKView draw] ()

Cedric · May 29, 2023, 8:57am

Does it happen as well if you create a box?

jihoobyeon · May 29, 2023, 12:20pm

Yes, same thing happens.

so we have to find what should be placed in g_platformData.nwh…

Cedric · May 29, 2023, 1:21pm

Looking at BabylonReactNative, looks like MTKView* is forwarded here:

github.com

BabylonJS/BabylonReactNative/blob/76388a0d1a83414326a2e0b614ab0e6bf05d09d1/Modules/@babylonjs/react-native-iosandroid/ios/BabylonNativeInterop.mm#LL62C35-L62C42


      
          BabylonNative::UpdateView(mtkView, width, height);

and used directly for nwh

github.com

BabylonJS/BabylonNative/blob/fee184cc8a5d82d45d22cb4ea7b66a835b90effb/Core/Graphics/Source/DeviceImpl_iOS.mm#L10


      
          #include <Babylon/Graphics/Platform.h>
          #include "DeviceImpl.h"
          
          
namespace Babylon::Graphics
          {
              const bool DeviceImpl::s_bgfxFlipAfterRender = true;
          
          
    void DeviceImpl::ConfigureBgfxPlatformData(bgfx::PlatformData& pd, WindowT window)
              {
                  pd.nwh = window;
              }
          
          
    float DeviceImpl::GetDevicePixelRatio(WindowT window)
              {
                  return window.contentScaleFactor;
              }
          }

I guess for MacOS, there is a equivalient to MTKView thatis created?

Cedric · May 29, 2023, 1:46pm

from bgfx source code on MacOS, it’s possible to provide the NSView, NSWindow or CAMetalLayer for the nwh

github.com

bkaradzic/bgfx/blob/e7e75e4bffbf9f0acc1de1dfe601313db6bda3f6/src/renderer_mtl.mm#L3260


      
          				NSObject* nvh = (NSObject*)_nwh;
          				if ([nvh isKindOfClass:[CAMetalLayer class]])
          				{
          					CAMetalLayer* metalLayer = (CAMetalLayer*)_nwh;
          					m_metalLayer = metalLayer;
          				}
          				else
          				{
          					NSView *contentView;
          
          
					if ([nvh isKindOfClass:[NSView class]])
          					{
          						contentView = (NSView*)nvh;
          					}
          					else if ([nvh isKindOfClass:[NSWindow class]])
          					{
          						NSWindow* nsWindow = (NSWindow*)nvh;
          						contentView = [nsWindow contentView];
          					}
          					else
          					{