Weird behavior with UniversalCamera and rotation property

Bugs
22

For me it also works in Firefox for Android, so it might be OS dependent. My original tests were on Windows.

1 Like
24

I tested on Mac where it worked too, so I guess the issue using quaternions is only on FireFox on Windows so far thenā€¦

But on other devices and browsers it seems like if it works when we convert from Euler angles to quaternion manually then it should be able to work when we let Babylon do that conversion for usā€¦ :thinking: :beers:

25

Hereā€™s a PR that fixes the issue in the below playground, which is the one that was created by @roland. Previously _rotateUpVectorWithCameraRotationMatrix was called only when the z property of the rotation changed, but now it is called if any property of the rotation vector changes. This fixed the issue for me on Chrome and Firefox on Mac. :slight_smile:

https://playground.babylonjs.com/#F68Z6N#4

1 Like
26

Who is da maaaan? You are da maaan! :muscle:

Thank you for solving the puzzle for usšŸ˜Ž

1 Like
27

Welp, my PR fixed one issue but looks like I broke some other things that fail validationā€¦ Hopefully it will help narrow down the search for a solution thou and I can take another try at it later tomorrow, but the puzzle continuesā€¦ :wink: :sleeping:

28

34996c8b3d6d35bc9a08bb20a95df8e0
34996c8b3d6d35bc9a08bb20a95df8e0920Ɨ517 89 KB

1 Like
29

Itā€™s the up vector test - Load GUI From Snippet Server | Babylon.js Playground (babylonjs.com)

It seems to not rotate when your changes are on:

image

1 Like
30

Thanks @RaananW, I made a little update to the PR that validates successfully and fixes that issue, by converting the rotation vector to a temp quaternion and then comparing that quaternionā€™s z value to the cached value. The idea was to update the upVector under the same circumstances as when a quaternion is used, which fixes the issue flagged in the playground.

Edit: on GitHub it says that itā€™s passed all the checks successfully now! :slightly_smiling_face:

1 Like
31

Hey @Blake, I just pulled your branch down and I just wanted to verify that your PR fixes just Scenario F and the modified form of Scenario F in that PG that rotates everything around. Is that correct? Reason Iā€™m asking is because Scenario B shows no change.

1 Like
32

Yes itā€™s only Scenario F that I was working on, it looks like itā€™s merged now thou, so Iā€™ll look into the others next when I get the chance, IDK if Iā€™ll have as much luck thou on any of those ones. :slight_smile: :beers:

3 Likes
33

Sounds good man! I appreciate you pushing up that fix.

2 Likes
36

Hi! Just checking up @PolygonalSun is there still an issue for the other scenarios? Want me to create a GitHub issue to track it? :slight_smile:

1 Like