ActionManager / PointerDragBehavior as a resource

zacherl · September 8, 2021, 2:26pm

Hello,

I’m currently wondering about action managers and pointer drag behaviors as resources (I hope I did not miss it in the documentation). We currently use several instances of action managers and pointer drag behaviors at the same time, e. g. when a new complex object is added, a new action manager and a new pointer drag behavior are created as well.

Since PointerDragBehavior creates a drag plane, I assume that it consumes resources. I checked the code - the drag plane is disposed when the scene is disposed. Do we pollute the memory if we create a lot of those behaviors? I did not find a dispose method on the behavior. Should I reuse them, can I apply the same behavior / action manager to multiple meshes at the same time? Or is there a method to dispose them when they are not used anymore?

Kind regards
Zacherl

Deltakosh · September 8, 2021, 3:05pm

pinging @Cedric

sebavan · September 8, 2021, 3:06pm

ActionManager should be fine and not having one per mesh can be difficult.

Regarding the PointerDragBehavior, as long as you detach the unneeded ones they should not have much cost.

zacherl · September 8, 2021, 3:24pm

Thank you for your quick answer!

I checked the code in the pointer drag behavior - the dragPlane is not disposed during detach, only some observers are removed. So you think the remaining drag planes are not an issue?

github.com

BabylonJS/Babylon.js/blob/master/src/Behaviors/Meshes/pointerDragBehavior.ts

import { Behavior } from "../../Behaviors/behavior";
import { Mesh } from "../../Meshes/mesh";
import { AbstractMesh } from "../../Meshes/abstractMesh";
import { Scene } from "../../scene";
import { Nullable } from "../../types";
import { Observer, Observable } from "../../Misc/observable";
import { Vector3 } from "../../Maths/math.vector";
import { PointerInfo, PointerEventTypes } from "../../Events/pointerEvents";
import { Ray } from "../../Culling/ray";
import { PivotTools } from '../../Misc/pivotTools';
import { ArcRotateCamera } from '../../Cameras/arcRotateCamera';
import "../../Meshes/Builders/planeBuilder";

/**
 * A behavior that when attached to a mesh will allow the mesh to be dragged around the screen based on pointer events
 */
export class PointerDragBehavior implements Behavior<AbstractMesh> {
    private static _AnyMouseId = -2;
    /**
     * Abstract mesh the behavior is set on

This file has been truncated. show original

sebavan · September 8, 2021, 3:30pm

so it will get disposed only when the main scene has been disposed. I do not think it consumes much memory but still I wonder if we could improve it, @Cedric ?

Cedric · September 8, 2021, 3:44pm

RAII, it should be disposed when detached. Let me do some tests …

Cedric · September 8, 2021, 4:23pm

I did a PR

zacherl · September 8, 2021, 4:47pm

Thank you all for your quick feedback!

Topic		Replies	Views
actionManager and PointerDragBehavior Questions pointerdragbehavior	3	439	May 19, 2023
PointerDragBehavior dragPlaneNormal problem Questions	4	1614	February 21, 2019
Dynamically changing pointerDragBehavior Questions	11	1404	December 4, 2019
Odd behavior in PointerDragBehavior Questions	5	407	August 31, 2021
How do you dispose the actions of an ActionManager Questions	10	772	September 6, 2023

ActionManager / PointerDragBehavior as a resource

Related Topics