Bug when parsing some #if in shaders

Evgeni_Popov · March 19, 2020, 11:37pm

More precisely, bug occurs for strings like:

#if DEBUGMODE_ == 1 && (defined(BUMP) || defined(PARALLAX) || defined(TATA))

where you have some parenthesis in the condition.

https://www.babylonjs-playground.com/#UXCB15#98

The cube should be white, it is red instead.

Commenting out #define PARALLAX makes it work, but commenting #define BUMP or #define TATA does not…

Replacing the expression by:

#if DEBUGMODE_ == 1 && defined(BUMP) || DEBUGMODE_ == 1 && defined(PARALLAX) || DEBUGMODE_ == 1 && defined(TATA)

make it work in all cases, so that’s why I think the problem lies in the parenthesis.

Deltakosh · March 20, 2020, 3:37pm

This should come somewhere from here:

github.com

BabylonJS/Babylon.js/blob/master/src/Engines/Processors/shaderProcessor.ts

import { ShaderCodeNode } from './shaderCodeNode';
import { ShaderCodeCursor } from './shaderCodeCursor';
import { ShaderCodeConditionNode } from './shaderCodeConditionNode';
import { ShaderCodeTestNode } from './shaderCodeTestNode';
import { ShaderDefineIsDefinedOperator } from './Expressions/Operators/shaderDefineIsDefinedOperator';
import { ShaderDefineOrOperator } from './Expressions/Operators/shaderDefineOrOperator';
import { ShaderDefineAndOperator } from './Expressions/Operators/shaderDefineAndOperator';
import { ShaderDefineExpression } from './Expressions/shaderDefineExpression';
import { ShaderDefineArithmeticOperator } from './Expressions/Operators/shaderDefineArithmeticOperator';
import { ProcessingOptions } from './shaderProcessingOptions';
import { _DevTools } from '../../Misc/devTools';

declare type WebRequest = import("../../Misc/webRequest").WebRequest;
declare type LoadFileError = import("../../Misc/fileTools").LoadFileError;
declare type IOfflineProvider = import("../../Offline/IOfflineProvider").IOfflineProvider;
declare type IFileRequest  = import("../../Misc/fileRequest").IFileRequest;

/** @hidden */
export class ShaderProcessor {
    public static Process(sourceCode: string, options: ProcessingOptions, callback: (migratedCode: string) => void) {

This file has been truncated. show original

Do you want me to investigate?

Evgeni_Popov · March 20, 2020, 4:56pm

Thanks, I’m going to have a look, I will let you know if I’m stuck.

Topic		Replies	Views
Bug in preprocessing shaders in 4.1.0-alpha.25 preview release Bugs	3	402	October 21, 2019
Im trying some gls shader but it throws error Questions shader	7	890	May 6, 2022
Missing `#ifdef` in `bumpFragment.fx`? Questions	3	238	July 8, 2021
Shader defines and comments Bugs	1	674	May 9, 2020
Possible bug in ShaderMaterial Bugs	5	292	October 14, 2019

Bug when parsing some #if in shaders

Related topics