Decoration function generateExpandMember error

tanpopo · February 7, 2025, 5:09am

packages/dev/core/src/Misc/decorators.ts

7aedc45bb


      
          function generateExpandMember(setCallback: string, targetKey: Nullable<string> = null) {

              return (target: any, propertyKey: string) => {

                  const key = targetKey || "_" + propertyKey;

                  Object.defineProperty(target, propertyKey, {

                      get: function (this: any) {

                          return this[key];

                      },

                      set: function (this: any, value) {

                          // does this object (i.e. vector3) has an equals function? use it!

                          // Note - not using "with epsilon" here, it is expected te behave like the internal cache does.

                          if (typeof this.equals === "function") {

                              if (this.equals(value)) {

                                  return;

                              }

                          }

                          if (this[key] === value) {

                              return;

                          }

                          this[key] = value;

          

                          target[setCallback].apply(this);

It seems we should judge the equation between this[key] and value, so this.equals should be this[key].equals instead in line 27 and line 28.

Deltakosh · February 7, 2025, 4:09pm

Seems legit! wanna try a PR?

Topic		Replies	Views
Possible bug when compiling BabylonJS with the Closure compiler Bugs	1	632	April 11, 2020
GlowLayer and NodeMaterials Bugs	3	417	December 20, 2021
Babylon stops rendering after 4-6 frames with Error: "[...] i.toArray is not a function " Questions	4	482	August 31, 2021
TypeScript Compiler Error Bugs	7	2414	March 13, 2019
Error with calling function FromHexString Bugs	2	1301	July 25, 2019

Decoration function generateExpandMember error

Related topics