ExtrasAsMetadata Bug

Hello guys,

I just upgraded my bjs app to beta-11. I noticed that the extension “ExtrasAsMetadata” is not working for meshes with armatures. So the metadata.gltf only has the “pointers” object but the “extras” one is missing. I checked the versions and it seems to happen for beta-8 and above. Beta-7 and everything below is working fine.

Best

@samevision could you share the file ? I can not find it anymore.

I created a pg. This works fine until beta-7: Babylon.js Playground

Oh I see, it is now on the “Cube” transform node when you have a skeleton http://localhost:1338/Playground/index-local.html?#FP6PPU#1 which is not part of the result list.

@bghgary changed this recently, and might have a look ?

1 Like

Fixed in this PR: Fix gltf extras with new skinning pattern by bghgary · Pull Request #12124 · BabylonJS/Babylon.js · GitHub

Sorry for the troubles!

3 Likes

You don’t have to apologize. I am very grateful for all your efforts!

2 Likes

Hey @bghgary,

I noticed that the error recurred. Now it breaks at 5.6.1. Can you give it a glance? :slight_smile:

Thank you!

Can you be more specific on what the error is? Also, we are already on 5.11.0, can you check that version?

EDIT: I tried the playground from the post above, but it seems the asset is no longer available.

Oh sorry for the confusion. There is no specific error but the metadata.gltf.extras object is missing again.

I tested all versions. It works until 5.6.0 and breaks for 5.6.1 and above.

1 Like

Can you create another repro? The other PG doesn’t work anymore.

Sure: https://playground.babylonjs.com/#FP6PPU#2

The metadata seems to be on the transform node https://playground.babylonjs.com/#FP6PPU#3

@bghgary might know more ?

Ah, yes, this is caused by my change. This will be slightly tricky to fix.

Sorry for the delay.

PR: Fix issue with glTF skin node/mesh metadata by bghgary · Pull Request #12684 · BabylonJS/Babylon.js (github.com)

2 Likes