GUI zIndex not updating

lihis · January 13, 2019, 1:39pm

This one was suuuuch a pain.

I tried making an example for this a week or two ago, but… well… ah whatever… i was able to reproduce my issues after all so that’s good.

https://www.babylonjs-playground.com/#7RH606#5

Edit: Also while i’m here, i would like to ask – when calling .dispose(), is the item supposed to disappear from my screen?

It used to - but now sometimes it doesn’t remove the item from screen and i have to manually remove them using removeControl().

Wingnut · January 13, 2019, 2:40pm

Hiya lihis! Good to see you again!

Umm… I think we have a bug… involving controls losing their .parent, at times.

https://www.babylonjs-playground.com/#7RH606#6

Is that working any better?

Notice lines 69/70. I have to FORCE the controls to have parents… periodically. Why? Cuzzzzzzz…

github.com

BabylonJS/Babylon.js/blob/master/gui/src/2D/controls/control.ts#L609


    return this._zIndex;
}


public set zIndex(value: number) {
    if (this.zIndex === value) {
        return;
    }


    this._zIndex = value;


    if (this.parent) {
        this.parent._reOrderControl(this);
    }
}


/** Gets or sets a boolean indicating if the control can be rendered */
public get notRenderable(): boolean {
    return this._doNotRender;
}


public set notRenderable(value: boolean) {

If the control has no parent… thisControl.parent._reOrderControl(thisControl); …never happens.

And if you nop-out lines 69/70, you can see at-console… that the children (controls) occasionally lose their parents (usually caused by parents walking too fast).

Children should always stay with their parents… forever… to save on rent.

Let’s ping-up Admiral @Deltakosh to have a little look at this… maybe tell us what we are screwing-up.

Comments from others… also welcome, of course, including info about disposing controls. The intermittent loss of control.parent… COULD be affecting disposal, too. (likely so, because a disposed child cannot find WHICH parent container to remove itself-from).

lihis · January 13, 2019, 2:51pm

Nice digging there Wingie!

Maybe the parent loosing thing could also be the reason why dispose() doesn’t always seem to remove items from the screen when in 3.3 it did? I don’t know though, but would kind of make sense

Edit: Nice edit there

Wingnut · January 13, 2019, 2:56pm

Thx! hehe… yeah, I was still thinking about disposal, and so were you. (hi5) synergy!

Yep, I think you might have found a BIG bug… a big hairy 8-legged thing… productivity-sucking fangs. Good job! You’re going to get your BJS BugBusters badge. Coooool.

Excellent issue-reproducing playground, too, Lihis! You rock!

Deltakosh · January 14, 2019, 4:35pm

Well this is not a bug per se but more a missing function
I’ll make sure to add it for next nightly and I’ll report back here when done

Deltakosh · January 14, 2019, 4:42pm

Well actually it was a huge fat bug Fixed now. Will be in next nightly and next npm update
This bug was also the reason why the dispose was sometimes not working

Sorry about the inconvenience and thanks for reporting it!

lihis · January 14, 2019, 7:36pm

Alright thanks guys

I did hi5 you back in my mind btw @Wingnut … sorry if it felt like i left you hanging
I suppose if there was a laaaaame joke involved, maybe i would leave you hanging, so it’s not impossible but not in this case

Topic		Replies	Views
GUI zIndex (in stackPanel) Questions gui	3	272	March 27, 2023
2D GUI elements not hiding in 5.2.0 Questions	9	459	April 19, 2022
[BJS GUI] Bug with mesh dispose Bugs	1	448	March 14, 2020
Engine.dispose() strange side effect Bugs	7	674	May 10, 2021
GUI Container: After the dispose is executed, the container’s children are not cleaned up Bugs	13	1361	December 15, 2018

GUI zIndex not updating

Related topics