Is it a bug in pbrBaseMaterial.ts?

SilverBullet · April 17, 2019, 12:23pm

Please look at the below two permalinks. We we declare uniform as “vSphericalXX”. But when setting values, we use the name “vSphericalXX_ZZ”.

github.com

BabylonJS/Babylon.js/blob/0c93dfc0d5c864038e166dcd8a4d92dca5be24df/src/Materials/PBR/pbrBaseMaterial.ts#L1173




var uniforms = ["world", "view", "viewProjection", "vEyePosition", "vLightsType", "vAmbientColor", "vAlbedoColor", "vReflectivityColor", "vEmissiveColor", "visibility", "vReflectionColor",

    "vFogInfos", "vFogColor", "pointSize",

    "vAlbedoInfos", "vAmbientInfos", "vOpacityInfos", "vReflectionInfos", "vReflectionPosition", "vReflectionSize", "vEmissiveInfos", "vReflectivityInfos",

    "vMicroSurfaceSamplerInfos", "vBumpInfos", "vLightmapInfos",

    "mBones",

    "vClipPlane", "vClipPlane2", "vClipPlane3", "vClipPlane4", "albedoMatrix", "ambientMatrix", "opacityMatrix", "reflectionMatrix", "emissiveMatrix", "reflectivityMatrix", "normalMatrix", "microSurfaceSamplerMatrix", "bumpMatrix", "lightmapMatrix",

    "vLightingIntensity",

    "logarithmicDepthConstant",

    "vSphericalX", "vSphericalY", "vSphericalZ",

    "vSphericalXX", "vSphericalYY", "vSphericalZZ",

    "vSphericalXY", "vSphericalYZ", "vSphericalZX",

    "vSphericalL00",

    "vSphericalL1_1", "vSphericalL10", "vSphericalL11",

    "vSphericalL2_2", "vSphericalL2_1", "vSphericalL20", "vSphericalL21", "vSphericalL22",

    "vReflectionMicrosurfaceInfos",

    "vTangentSpaceParams", "boneTextureWidth",

    "vDebugMode"

];



var samplers = ["albedoSampler", "reflectivitySampler", "ambientSampler", "emissiveSampler",

github.com

BabylonJS/Babylon.js/blob/0c93dfc0d5c864038e166dcd8a4d92dca5be24df/src/Materials/PBR/pbrBaseMaterial.ts#L1692


    this._activeEffect.setVector3("vSphericalL2_2", preScaledHarmonics.l2_2);

    this._activeEffect.setVector3("vSphericalL2_1", preScaledHarmonics.l2_1);

    this._activeEffect.setVector3("vSphericalL20", preScaledHarmonics.l20);

    this._activeEffect.setVector3("vSphericalL21", preScaledHarmonics.l21);

    this._activeEffect.setVector3("vSphericalL22", preScaledHarmonics.l22);

}

else {

    this._activeEffect.setFloat3("vSphericalX", polynomials.x.x, polynomials.x.y, polynomials.x.z);

    this._activeEffect.setFloat3("vSphericalY", polynomials.y.x, polynomials.y.y, polynomials.y.z);

    this._activeEffect.setFloat3("vSphericalZ", polynomials.z.x, polynomials.z.y, polynomials.z.z);

    this._activeEffect.setFloat3("vSphericalXX_ZZ", polynomials.xx.x - polynomials.zz.x,

        polynomials.xx.y - polynomials.zz.y,

        polynomials.xx.z - polynomials.zz.z);

    this._activeEffect.setFloat3("vSphericalYY_ZZ", polynomials.yy.x - polynomials.zz.x,

        polynomials.yy.y - polynomials.zz.y,

        polynomials.yy.z - polynomials.zz.z);

    this._activeEffect.setFloat3("vSphericalZZ", polynomials.zz.x, polynomials.zz.y, polynomials.zz.z);

    this._activeEffect.setFloat3("vSphericalXY", polynomials.xy.x, polynomials.xy.y, polynomials.xy.z);

    this._activeEffect.setFloat3("vSphericalYZ", polynomials.yz.x, polynomials.yz.y, polynomials.yz.z);

    this._activeEffect.setFloat3("vSphericalZX", polynomials.zx.x, polynomials.zx.y, polynomials.zx.z);

}

Deltakosh · April 17, 2019, 1:47pm

Pinging @sebavan

sebavan · April 17, 2019, 2:00pm

Definitely a bug, I will fix it ASAP.

sebavan · April 17, 2019, 2:14pm

Done and merged, this will be available in the next nightly.

Thanks a lot for your sharp eyes, I have no clue how you noticed this one but THANKS !!!

SilverBullet · April 18, 2019, 12:49am

With pleasures! Hum…actually by reading the source code of an outstanding opensource project is always a good way of learning things, isn’t it?

Topic		Replies	Views
Possible bug with uniforms in PBRCustomMaterial Bugs	17	698	October 18, 2019
How to specify custom spherical harmonics? Questions	8	533	January 31, 2022
Adding uniforms in custom materials Bugs	5	693	June 25, 2020
Can't set uniform for PBRCustomMaterial Bugs	4	784	July 30, 2019
Custom material quick question Questions	4	858	April 5, 2020

Is it a bug in pbrBaseMaterial.ts?

Related topics