Minor performance question :)

nekochanoide · February 9, 2021, 11:17am

I don’t know if this really important. Anyway, tested this function and got better result with Math.abs() function. If it really faster then it may be fine change to that, I guess…

github.com

BabylonJS/Babylon.js/blob/7b71ec024d75b0bd17cc6bc87a8323f5fba039af/src/Maths/math.scalar.ts#L18-L21


public static WithinEpsilon(a: number, b: number, epsilon: number = 1.401298E-45): boolean {
    var num = a - b;
    return -epsilon <= num && num <= epsilon;
}

https://playground.babylonjs.com/#ZI4ENX#1

Deltakosh · February 9, 2021, 4:37pm

OMG this is excellent!! Do you want to send a PR? You deserve to get some credits!

nekochanoide · February 10, 2021, 3:59am

Done.

Topic		Replies	Views
BABYLON.Epsilon is too big and readonly Bugs	4	1158	March 28, 2019
How to do high precision transformations? Questions	11	1948	April 12, 2019
Mathematical Way/Tools I Used Announcements	19	2142	February 22, 2021
How do you prevent obscure bugs with Vector3.Distance and floating numbers? Questions	4	361	February 7, 2023
Babylon.js v4.0 entering code lock mode :) Announcements	2	487	April 30, 2019

Minor performance question :)

Related topics