Minor performance question :)

nekochanoide · February 9, 2021, 11:17am

I don’t know if this really important. Anyway, tested this function and got better result with Math.abs() function. If it really faster then it may be fine change to that, I guess…

github.com

BabylonJS/Babylon.js/blob/7b71ec024d75b0bd17cc6bc87a8323f5fba039af/src/Maths/math.scalar.ts#L18-L21


public static WithinEpsilon(a: number, b: number, epsilon: number = 1.401298E-45): boolean {
    var num = a - b;
    return -epsilon <= num && num <= epsilon;
}

https://playground.babylonjs.com/#ZI4ENX#1

Deltakosh · February 9, 2021, 4:37pm

OMG this is excellent!! Do you want to send a PR? You deserve to get some credits!

nekochanoide · February 10, 2021, 3:59am

Done.

Topic		Replies	Views
Mathematical Way/Tools I Used Announcements	19	1962	February 22, 2021
Some recommended big decimals library to use besides BabylonJs? Questions	4	437	July 22, 2021
BABYLON.Epsilon is too big and readonly Bugs	4	1021	March 28, 2019
Decimals and Measurement System Questions	6	1352	August 12, 2022
Refactoring for BABYLON.JS core Feature requests	2	571	February 10, 2020

Minor performance question :)

Related Topics