Need to call resetDrawCache before setMaterialForRendering?

Blake · May 23, 2022, 3:20pm

When calling setMaterialForRendering() on an effect, if changing e.g. from a StandardMaterial to a NodeMaterial (or vice versa) then a runtime error crashes the page…

And from checking the source and debugging I eventually found that a workaround is to first call resetDrawCache() on the mesh like below (comment this reset out on line 23 to see the error in the console).

So I wonder if setMaterialForRendering() should call resetDrawCache() on the mesh that we pass in for us to prevent this error? Or some other solution?

PS the node material in the playground is just the default saved from NME, so just sets the color to white.

Evgeni_Popov · May 23, 2022, 4:49pm

Yes, I think this call should be done. It had already been fixed in the glow layer when calling referenceMeshToUseItsOwnMaterial and unReferenceMeshFromUsingItsOwnMaterial for this very reason:

github.com

BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Layers/glowLayer.ts#L580-L601

      
        
            public referenceMeshToUseItsOwnMaterial(mesh: AbstractMesh): void {

                mesh.resetDrawCache(this._mainTexture.renderPassId);

            

                this._meshesUsingTheirOwnMaterials.push(mesh.uniqueId);

            

                mesh.onDisposeObservable.add(() => {

                    this._disposeMesh(mesh as Mesh);

                });

            }

            

            /**

             * Remove a mesh from being rendered through its own material and not with emissive only.

             * @param mesh The mesh for which we need to not use its material

             */

            public unReferenceMeshFromUsingItsOwnMaterial(mesh: AbstractMesh): void {

                let index = this._meshesUsingTheirOwnMaterials.indexOf(mesh.uniqueId);

                while (index >= 0) {

                    this._meshesUsingTheirOwnMaterials.splice(index, 1);

                    index = this._meshesUsingTheirOwnMaterials.indexOf(mesh.uniqueId);

                }

This file has been truncated. show original

Fancy doing a PR for that? (note that you should reset the draw cache only for this._mainTexture.renderPassId).

Blake · May 23, 2022, 5:09pm

OK here it is, I actually ended up adding it to setMaterialForRenderPass to make the fix more general.

Topic		Replies	Views
Setting texture with setTexture() on custom material after creation has no effect? Questions	9	740	February 24, 2023
NodeMaterial Self Lighting Questions	15	626	October 14, 2019
Mesh "flickering" when setting material initially Questions	3	290	January 12, 2023
Shader Flickering when calling setTexture Questions material , shader	1	506	August 17, 2020
NodeMaterial change based on the mesh? Questions material , shader	5	410	November 24, 2020

Need to call resetDrawCache before setMaterialForRendering?

Related Topics