New PBR Shader Breaking Changes

[Evgeni_Popov]

Here’s an example using the feature:

Issue Setting Color of Thin Instance

This one is a little more involved because there’s no simple way to inject some code just after the alpha texture has been sampled. You can use a feature that allows to tamper with the shader source code just before it is sent to the GPU to replace the alpha sampling code by your own (lines 51-64): https://www.babylonjs-playground.com/#KWVY94#10 You can also write your own shader with ShaderMaterial but it’s even more involved. You could also write a node material in the NME, using for eg uv…

In your code, you don’t need to do any replace like in the example but instead you need to inline the code by doing:

        const sci = new BABYLON.ShaderCodeInliner(code);
        sci.inlineToken = "#define pbr_inline";
        sci.processCode();
        return sci.code;

@MackeyK24

Yo @Evgeni_Popov … SO if i am now using the processFinalCode method… Do i still need to do this ???

fragment = fragment.replace(/#include<pbrBlockAlbedoOpacity>/g, BABYLON.Effect.IncludesShadersStore["pbrBlockAlbedoOpacity"]);
fragment = fragment.replace(/#include<pbrBlockReflectivity>/g, BABYLON.Effect.IncludesShadersStore["pbrBlockReflectivity"]);
fragment = fragment.replace(/#include<pbrBlockFinalColorComposition>/g, BABYLON.Effect.IncludesShadersStore["pbrBlockFinalColorComposition"]);

No, you don’t need to do this anymore once you use processFinalCode.