Nme missing .animationType in generated code

ycw · November 14, 2019, 8:11pm

Screenshot_2019-11-15%20Babylon%20js%20Node%20Material%20Editor

generated code

...
var Time = new BABYLON.InputBlock("Time");
Time.animationType = BABYLON.AnimatedInputBlockTypes.Time; // <-- missing 
...

PirateJC · November 14, 2019, 9:01pm

@ycw - This an awesome catch!!!

Pinging @Deltakosh

Deltakosh · November 14, 2019, 9:19pm

Fixed!

ycw · November 15, 2019, 3:09am

lets elaborate the problem:

reproduce:

visit this graph: Babylon.js Node Material Editor
click “generate code”
open code.txt

Expected: InputBlock, “Time”, should be assigned .animationType like below
Time.animationType = BABYLON.AnimatedInputBlockTypes.Time;

Actual: missing

Deltakosh · November 15, 2019, 3:41am

Refresh your cache:) it should work now

ycw · November 15, 2019, 6:29am

Should L577 stuff also be added to L556 ?

L577:

github.com

BabylonJS/Babylon.js/blob/f5fdfbb8bb0ef1e564b6592f4b771fcf30a735d7/src/Materials/Node/Blocks/Input/inputBlock.ts#L577


      
                      case NodeMaterialBlockConnectionPointTypes.Color3:

                          valueString = `new BABYLON.Color3(${this.value.r}, ${this.value.g}, ${this.value.b})`;

                          break;

                      case NodeMaterialBlockConnectionPointTypes.Color4:

                          valueString = `new BABYLON.Color4(${this.value.r}, ${this.value.g}, ${this.value.b}, ${this.value.a})`;

                          break;

                  }

                  let finalOutput = `${this._codeVariableName}.value = ${valueString};\r\n`;

                  finalOutput += `${this._codeVariableName}.isConstant = ${this.isConstant ? "true" : "false"};\r\n`;

                  finalOutput += `${this._codeVariableName}.visibleInInspector = ${this.visibleInInspector ? "true" : "false"};\r\n`;

                  finalOutput += `${this._codeVariableName}.animationType  = BABYLON.AnimatedInputBlockTypes.${AnimatedInputBlockTypes[this.animationType]};\r\n`;

          

                  return finalOutput;

              }

              return "";

          }

          

          public serialize(): any {

              let serializationObject = super.serialize();

          

              serializationObject.type = this.type;

L556:

github.com

BabylonJS/Babylon.js/blob/f5fdfbb8bb0ef1e564b6592f4b771fcf30a735d7/src/Materials/Node/Blocks/Input/inputBlock.ts#L556


      
          }

          if (this.isUniform) {

              let valueString = "";

              switch (this.type) {

                  case NodeMaterialBlockConnectionPointTypes.Float:

                      let returnValue = `${this._codeVariableName}.value = ${this.value};\r\n`;

          

                      returnValue += `${this._codeVariableName}.min = ${this.min};\r\n`;

                      returnValue += `${this._codeVariableName}.max = ${this.max};\r\n`;

                      returnValue += `${this._codeVariableName}.matrixMode = ${this.matrixMode};\r\n`;

          

                      return returnValue;

                  case NodeMaterialBlockConnectionPointTypes.Vector2:

                      valueString = `new BABYLON.Vector2(${this.value.x}, ${this.value.y})`;

                      break;

                  case NodeMaterialBlockConnectionPointTypes.Vector3:

                      valueString = `new BABYLON.Vector3(${this.value.x}, ${this.value.y}, ${this.value.z})`;

                      break;

                  case NodeMaterialBlockConnectionPointTypes.Vector4:

                      valueString = `new BABYLON.Vector4(${this.value.x}, ${this.value.y}, ${this.value.z}, ${this.value.w})`;

                      break;

Deltakosh · November 15, 2019, 3:55pm

I’m freaking stupid!! Sorry for the burden

I’ll fix that right now

ycw · November 15, 2019, 8:33pm

It works now.

Thanks

Topic		Replies	Views
Node Material Editor doesn't properly generate code for Trigonometry Blocks Bugs	1	288	November 4, 2019
NME code gen missing required params for Texture Questions	3	558	March 8, 2020
How to type data for Animation.Parse in Babylon.js? Questions documentation	5	39	November 28, 2024
Bugs appeared recently in the last hour Bugs	12	391	March 17, 2022
I am trying to run an animation from a nme variable? Questions	5	337	September 4, 2020

Nme missing *.animationType* in generated code

Related topics

Nme missing .animationType in generated code