Rectangle corner radius doesn’t scale properly with AdvancedDynamicTexture that has an ideal size

[dinutaleanu]

Hello, I found another issue with ADT ideal sizing scaling. It appears that the corner radius doesn’t scale when ADT ideal sizing is set.

Here’s a playground showcasing the issue: https://playground.babylonjs.com/#DDTSY8#1

I have posted about 2 similar issues in the past:

StackPanel spacing doesn't scale properly with AdvancedDynamicTexture that has an ideal size

Hello, I recently made a post about TextBlock.shadowOffset not scaling properly when added to an AdvancedDynamicTexture that has and ideal size set. (Shadow offset of a textBlock doesn't scale properly with AdvancedDynamicTexture that has an ideal size) I found another issue similar to that one, this time regarding StackPanel and spacing. Since the other issue was a bug with the engine, I’m inclined to believe this one is as well. I created a playground replicating the issue: https://playgro…

Shadow offset of a textBlock doesn't scale properly with AdvancedDynamicTexture that has an ideal size

OK @dinutaleanu, I’m done investigating, and I believe you found a bug! When using the adaptive scaling feature (ideal width and height), all pixel values are supposed to be scaled, but the shadowOffsetX and shadowOffsetY values were not. I’ve got a fix in this PR: GUI 2D: Fix shadowOffsetX and shadowOffsetY to respect adaptive scaling by AmoebaChant · Pull Request #17377 · BabylonJS/Babylon.js · GitHub FYI: I tried a little workaround in Babylon.js Playground where I modify shadowOffsetX and…

Thanks for the help, guys!

[amoebachant]

Hi @dinutaleanu - thanks for reporting this and providing a playground, I’ll take a look!

[amoebachant]

Nice catch @dinutaleanu — confirmed it’s the same class of bug as the previous two. Rectangle.cornerRadius is a raw number (not ValueAndUnit), so it wasn’t being multiplied by idealRatio like thickness and shadowOffsetX/Y are. Fix is up here: GUI 2D: Fix Rectangle cornerRadius to respect adaptive scaling by AmoebaChant · Pull Request #18354 · BabylonJS/Babylon.js · GitHub — _drawRoundedRect now scales the corner radii by host.idealRatio to match the rest of the adaptive-scaling pipeline.

Thanks for the playground!