Vertex error and no colors on thin instances after upgrade

[Blake]

Hmm, after copying over the instancesCount then it works:

clone._thinInstanceDataStorage.instancesCount = source._thinInstanceDataStorage.instancesCount;

For example here’s your PG with this fix and also here’s a simpler PG to show the issue (if you comment out line 45 then you can see how it isn’t working without setting the instancesCount).

EDIT: I started a new thread for this issue of needing to set the internal count directly since it turned out to be unrelated.

Can't set thinInstanceCount for clone

Heya, while investigating a separate issue on this thread I stumbled onto an issue where the thinInstanceCount for a clone can’t be set to any value except for zero. Here’s a simple PG to show the issue. It looks like a simple way to fix it is to fall back on using the source mesh to compute the clone’s numMaxInstances value, like on this PR for example.