Apparent memory leak in RecastJS

Bugs
1

Howdy!

We’re tracing down an occasional crash that occurs in a long-running session. When it occurs, the Babylon scene freezes (but HTML overlays remain functional) and the console reports:

Uncaught abort(OOM), Build with -s ASSERTIONS=1 for more info with a code location that points to RecastJS.

To investigate, I started a scene and then, after loading and initial stabilization, I ran Chrome’s memory allocation timelines tool, which is designed to troubleshoot memory leaks by identifying objects that remain in memory without getting garbage collected for long periods of time.

The results show Vec3 objects from recast.js are continuously allocated and remain in memory for at least 5 minutes.

image
image1004×473 68.9 KB

2 Likes
2

Here’s how we’re using Recast in our render loop:

const newCameraPositionXZ = navigationPlugin.moveAlong(
  camera.lastPosition,
  candidateCameraPosition
);
const newCameraPosition = navigationPlugin.getClosestPoint(
  newCameraPositionXZ
);
3

This is one part of our never-ending quest to help Frame run better on Safari, @Cedric :cold_face:

But yeah, this does also freeze MY machine and I’m on an absolute beast i9 and rtx 3090 etc.

4

Say no more! I’m on it! Thank you for invaluable investigation!

1 Like
5

PR is live : [Navigation] Limit new objects for garbage collection by CedricGuillemet · Pull Request #10301 · BabylonJS/Babylon.js · GitHub

1 Like
6

This is awesome, thank you @Cedric . Looking forward to trying this out!

1 Like
7

Let me know if it works for you. I did this change blindly as it’s the only place I found that allocated Vec3.

2 Likes
8

Hey @Cedric we’re pretty sure this problem is resolved, thanks! After your patch, Recast’s memory footprint is completely flat and we haven’t observed the crash.

3 Likes
9

@Cedric, GG

1 Like