Changing targetScreenOffset of clone, changes it on the clone origin

Bugs
1

I just found a small bug, when creating a clone of an ArcRotateCamera and updating the targetScreenOffset, to reproduce:

  • Create ArcRotateCamera
  • Clone the camera
  • Log targetScreenOffset of source camera
  • Update targetScreenOffset on cloned camera
  • Log targetScreenOffset of source camera

The value of the second log changed, although it was updated on the cloned camera. Probably the original and clone hold a reference to the same Vector2

Playground (check the console logs):

1 Like
2

thanks a lot for the thorough report I ll fix it tonight :slight_smile:

4

Hi!

I believe, the targetScreenOffset property is incorrectly identified by the serializable decorator and it marks the property as a value based so it doesn’t clone the object just sets the reference on the clone to the existing Vector2:

image

image
image908×436 20.6 KB

The author of the code will help more here! :slight_smile:

5

:stuck_out_tongue: I am late :smiley:

6

Should be fixed in the next nightly Fix camera targetScreenOffset serialization by sebavan · Pull Request #12078 · BabylonJS/Babylon.js · GitHub

1 Like
8

Yeah sure! I was reliefed I finally found the bug I was hunting for an hour :grimacing: Thanks for the quick fix and keep up the good work :+1:

2 Likes
9

Enjoy the cake! I had my first anniversary yesterday and had a real cake to celebrate :smiley:

1 Like