DOC: `markAllAsDirty` is unnecessary in Material Plugins?

Questions
1

Accroding to Material Plugins | Babylon.js Documentation

// we need to mark the material
this.markAllAsDirty = material._dirtyCallbacks[BABYLON.Constants.MATERIAL_AllDirtyFlag];

Seems it has been replaced by Babylon.js/materialPluginBase.ts at 5.2.0 · BabylonJS/Babylon.js · GitHub

So the doc can remove this line safely?

2

I think so…asking @everyone for a second thought

3

Yeah I don’t see any problem. @yuqian want to open a PR for the docs? :smile:

4

Yes, this helper has been added after the docs have been written.

1 Like
5

PR opened :smiley:

3 Likes