False False statement on BJS deviceInputSystem passive param?

Pryme8 · January 25, 2021, 11:13pm

BabylonJS/Babylon.js/blob/cd31eb68e67afe5f2e879a87e67e11d130fad11a/src/DeviceInput/deviceInputSystem.ts#L535


                    this.onInputChanged(deviceType, deviceSlot, PointerInput.MouseWheelZ, previousWheelScrollZ, pointer[PointerInput.MouseWheelZ], evt);
                }
            }
        }
    });

    this._elementToAttachTo.addEventListener(this._eventPrefix + "move", this._pointerMoveEvent);
    this._elementToAttachTo.addEventListener(this._eventPrefix + "down", this._pointerDownEvent);
    this._elementToAttachTo.addEventListener(this._eventPrefix + "up", this._pointerUpEvent);
    this._elementToAttachTo.addEventListener("blur", this._pointerBlurEvent);
    this._elementToAttachTo.addEventListener(this._wheelEventName, this._pointerWheelEvent, passiveSupported ? { passive: false } : false);
}

/**
 * Handle all actions that come from gamepad interaction
 */
private _handleGamepadActions() {
    this._gamepadConnectedEvent = ((evt: any) => {
        this._addGamePad(evt.gamepad);
    });

From looking at the code I would imagine it should be like this.

passiveSupported ? { passive: true} : false

Deltakosh · January 25, 2021, 11:36pm

No actually because we DO not want passive (I guess, adding @PolygonalSun )

Topic		Replies	Views
Babylon forcing non-passive events? Bugs	4	461	March 11, 2022
Updated Babylon now getting Unable to preventDefault inside passive event listener invocation. error Questions	4	656	July 5, 2022
Chrome warning about non-passive event listener for wheel event Bugs	3	4116	January 12, 2021
WebDeviceInputSystem._pointerCancelEvent Uncaught TypeError: Cannot set property '2' of undefined Bugs	4	303	November 15, 2023
Keyboard events stopped working Questions	7	508	April 22, 2021

False False statement on BJS deviceInputSystem passive param?

Related topics