Incorrect lodScale value in CubeTexture constructor

tokareuv · July 3, 2024, 1:21pm

While this may not be considered as actually a bug, it’s definitely unexpected behaviour.
Here’s an example:

Due to caching of loaded textures please comment/uncomment each shape individually to see the problem.
CubeTexture constructor defines lodScale with default value 0.8, but if cube texture creation options are present, default value is 0.0.

github.com

BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Materials/Textures/cubeTexture.ts#L268


      
          

          if (extensionsOrOptions !== null && !Array.isArray(extensionsOrOptions)) {

              extensions = extensionsOrOptions.extensions ?? null;

              this._noMipmap = extensionsOrOptions.noMipmap ?? false;

              files = extensionsOrOptions.files ?? null;

              buffer = extensionsOrOptions.buffer ?? null;

              this._format = extensionsOrOptions.format ?? Constants.TEXTUREFORMAT_RGBA;

              prefiltered = extensionsOrOptions.prefiltered ?? false;

              forcedExtension = extensionsOrOptions.forcedExtension ?? null;

              this._createPolynomials = extensionsOrOptions.createPolynomials ?? false;

              this._lodScale = extensionsOrOptions.lodScale ?? 0;

              this._lodOffset = extensionsOrOptions.lodOffset ?? 0;

              this._loaderOptions = extensionsOrOptions.loaderOptions;

              this._useSRGBBuffer = extensionsOrOptions.useSRGBBuffer;

              onLoad = extensionsOrOptions.onLoad ?? null;

              onError = extensionsOrOptions.onError ?? null;

          } else {

              this._noMipmap = noMipmap;

              this._format = format;

              this._createPolynomials = createPolynomials;

              extensions = extensionsOrOptions;

Here’s a line in the constructor with this definition.

roland · July 3, 2024, 4:04pm

Hello and welcome onboard!

I strongly believe, It has to be equal. Will you do a PR and set the correct value at line 268?

sebavan · July 3, 2024, 9:05pm

Thanks a lot for reporting it

tokareuv · July 4, 2024, 6:53am

Thanks a lot for the quick fix!

Topic		Replies	Views
ObjectUrl doesn't work in the CubeTexture constructor Bugs	1	292	August 25, 2022
CubeTexture files array bug Bugs	2	381	November 11, 2022
`texture.textureFormat` does not return right value Bugs material , texture	5	146	May 2, 2024
Missing default value for `generateMipMaps` in dynamic texture constructor Bugs	2	315	January 24, 2021
`CubeTexture.CreateFromPrefilteredData` does not work with URL that contains URI params Bugs	6	640	September 29, 2022

Incorrect lodScale value in CubeTexture constructor

Related topics