Any chance we can replace
generateMipMaps: boolean
with
generateMipMaps: boolean = false
in DynamicTexture.constructor please?
Docs describe it as false by default but it is you using TypeScript it will be marked as required.
* Creates a DynamicTexture
* @param name defines the name of the texture
* @param options provides 3 alternatives for width and height of texture, a canvas, object with width and height properties, number for both width and height
* @param scene defines the scene where you want the texture
* @param generateMipMaps defines the use of MinMaps or not (default is false)
* @param samplingMode defines the sampling mode to use (default is Texture.TRILINEAR_SAMPLINGMODE)
* @param format defines the texture format to use (default is Engine.TEXTUREFORMAT_RGBA)
* @param invertY defines if the texture needs to be inverted on the y axis during loading
*/
constructor(name: string, options: any, scene: Nullable<Scene> = null, generateMipMaps: boolean, samplingMode: number = Constants.TEXTURE_TRILINEAR_SAMPLINGMODE, format: number = Constants.TEXTUREFORMAT_RGBA, invertY?: boolean) {
super(null, scene, !generateMipMaps, invertY, samplingMode, undefined, undefined, undefined, undefined, format);
this.name = name;
this.wrapU = Texture.CLAMP_ADDRESSMODE;
this.wrapV = Texture.CLAMP_ADDRESSMODE;
this._generateMipMaps = generateMipMaps;
const engine = this._getEngine();
if (!engine) {
You’re right, here’s the PR:
BabylonJS:master ← Popov72:master
opened 01:20PM - 23 Jan 21 UTC
I don’t understand why Typescript does not catch this one…
Nice one. Should have probably submit it myself!
I don’t understand why Typescript does not catch this one…
All the arguments (starting from) have default value set, generateMipMaps is the only one that is missing, so that makes it required. In fact that forces scene value to be passed in as well, negating it being null by default.
Thanks for the fix @Evgeni_Popov . Looking forward to the merge.
Will do next time.