Lint:fix script missing from package.json

Bugs
1

Hi @RaananW !

npm run lint calls:

"lint": "npm run lint:check && npm run lint:fix" but lint:fix is not defined in package.json

npm run lint

> @babylonjs/root@1.0.0 lint
> npm run lint:check && npm run lint:fix


> @babylonjs/root@1.0.0 lint:check
> eslint "packages/**/src/**/*.{ts,tsx,js,json}" --quiet

npm ERR! Missing script: "lint:fix"
npm ERR! 
npm ERR! To see a list of scripts, run:
npm ERR!   npm run

Can you check it please?

Thanks!

EDIT: one more from today after pullin master from upstream:

> @tools/test-tools@1.0.0 clean
> rimraf dist && rimraf *.tsbuildinfo

/Users/roland.csibrei/code/Babylon.js/node_modules/rimraf/bin.js:46
      throw er
      ^

[Error: EACCES: permission denied, unlink 'dist/index.d.ts'] {
  errno: -13,
  code: 'EACCES',
  syscall: 'unlink',
  path: 'dist/index.d.ts'
}

Node.js v18.18.2
npm ERR! Lifecycle script `clean` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: @tools/test-tools@1.0.0 
npm ERR!   at location: /Users/roland.csibrei/code/Babylon.js/packages/tools/testTools 
npm ERR! Lifecycle script `build` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: @tools/test-tools@1.0.0 
npm ERR!   at location: /Users/roland.csibrei/code/Babylon.js/packages/tools/testTools 
npm ERR! code 1
npm ERR! path /Users/roland.csibrei/code/Babylon.js
npm ERR! command failed
npm ERR! command sh -c ts-patch install -s && npm run build:tools && npm i @dev/build-tools -D && npm run build:assets && npm run build:test-tools

npm ERR! A complete log of this run can be found in: /Users/roland.csibrei/.npm/_logs/2024-04-04T10_26_06_783Z-debug-0.log

I tried it in an elevated terminal session.

3

@RaananW is out this week. He will be back next week. It looks like lint:fix was removed with this commit.

1 Like
4

oh, will need to remove that, thanks for catching that. lint:fix was removed as a script, because autofix does wonders to our codebase for no reason. I’ll check later this week if I can simply disable autofix on some of the rules to allow lint fixing.
In any way, lint:check works so you can see what will fail in the CI if you want to be sure.

1 Like
5

Thanks!