Make it easier to stop default render loop on playground

Blake · January 14, 2022, 4:25pm

It seems like the playground should call engine.runRenderLoop() BEFORE calling createScene, that way we can stop the default renderLoop and start a custom one without having to use setTimeout to wait for it to be created. Looking at the PG implementation it seems like a pretty straightforward change to make…

Deltakosh · January 14, 2022, 4:38pm

Please do a PR as long as it does not break anything I’m totally fine with it

Blake · January 14, 2022, 7:03pm

Awesome, here’s the PR! From my initial tests it looks like I didn’t break anything, just moved things around a bit.

github.com/BabylonJS/Babylon.js

PG: Start render loop before creating scene

BabylonJS:master ← BlakeOne:master

opened 06:59PM - 14 Jan 22 UTC

BlakeOne

+31 -24

PR for playground to start the default render loop before calling the scene crea…tion function, so that we can stop it and start a new one without having to use setTimeout() to wait for the default be started. Basically the current code to start the render loop is moved into a hidden public method which is called after creating the engine, right before calling the user function that creates the scene. Forum discussion: https://forum.babylonjs.com/t/make-it-easier-to-stop-default-render-loop-on-playground/26749/2

Topic		Replies	Views
How to stop render loop in playground? Questions	4	593	December 3, 2022
How to prevent runRenderLoop to render scene when user does not interact in the scene and the scene is static Questions engine , rendering , scene	6	581	January 31, 2023
PlayGround sample.zip stops to work Bugs	2	201	January 22, 2022
Run Button Code Questions	5	401	August 22, 2020
Where is the game loop? Questions	3	381	September 15, 2023

Make it easier to stop default render loop on playground

Related Topics