Pbr custom shader failed to load

phaselock · May 23, 2019, 2:59am

So this was working before, now it won’t load. I can’t spot anything that might be from the nightly build. console shows ‘varying’ : Illegal use of reserved word
Help ?

https://www.babylonjs-playground.com/#0GG6MR#28

phaselock · May 23, 2019, 4:19am

ok, so the pg works if the ‘varying’ keyword is now removed. Appears that some work is being done on shaderProcessor that’s breaking stuff. On my local machine, scene.render is throwing ‘computeShadowWithPCF5’ : no matching overloaded function found.

Gonna give it a few days for this to clear up. Cheers !

sebavan · May 23, 2019, 7:38am

Sorry about that, we ll check with @Deltakosh ASAP and yes it might be the new Processor breaking it.

This will get fixed today.

sebavan · May 23, 2019, 8:12am

It is due to the processing taking varying or attributes only on the line start not inside:

github.com

BabylonJS/Babylon.js/blob/master/src/Engines/Processors/shaderCodeNode.ts#L20


isValid(preprocessors: { [key: string]: string }): boolean {

    return true;

}



process(preprocessors: { [key: string]: string }, options: ProcessingOptions): string {

    let result = "";

    if (this.line) {

        let value: string = this.line;

        let processor = options.processor;

        if (processor) {

            if (processor.attributeProcessor && this._lineStartsWith("attribute")) {

                value = processor.attributeProcessor(this.line);

            } else if (processor.varyingProcessor && this._lineStartsWith("varying")) {

                value = processor.varyingProcessor(this.line, options.isFragment);

            }

        }



        result += value + "\r\n";

    }



    this.children.forEach((child) => {

github.com

BabylonJS/Babylon.js/blob/master/src/Engines/Processors/shaderCodeNode.ts#L22


}



process(preprocessors: { [key: string]: string }, options: ProcessingOptions): string {

    let result = "";

    if (this.line) {

        let value: string = this.line;

        let processor = options.processor;

        if (processor) {

            if (processor.attributeProcessor && this._lineStartsWith("attribute")) {

                value = processor.attributeProcessor(this.line);

            } else if (processor.varyingProcessor && this._lineStartsWith("varying")) {

                value = processor.varyingProcessor(this.line, options.isFragment);

            }

        }



        result += value + "\r\n";

    }



    this.children.forEach((child) => {

        result += child.process(preprocessors, options);

    });

In your case the varying appears in the middle of the line:

uniform mat4 textureMatrix;varying vec2 vUv;

I guess we should expand this but I ll check with @Deltakosh later today to be sure we are doing it wisely

Deltakosh · May 23, 2019, 3:13pm

I’m on it ;D

phaselock · May 25, 2019, 12:13pm

Another one for you, this one is from the doc on shadows:

https://playground.babylonjs.com/#B48X7G#1
https://playground.babylonjs.com/#B48X7G#2

console throws:
‘computeShadowWithPCF5’ : no matching overloaded function found
‘computeShadowWithPCSS64’ : no matching overloaded function found

Deltakosh · May 25, 2019, 1:50pm

Good catch! I’ll fix that asap

Topic		Replies	Views
App that worked for months (using NME materials) suddenly hangs with shader errors Bugs	8	410	July 14, 2023
Bug from nowWhere + Bug with 4.1.0 Bugs	65	3656	December 9, 2019
Cascaded shadows on chrome canary Questions	6	1569	October 29, 2021
Varying `v_uv` has static-use in the frag shader, but is undeclared in the vert shader Questions shader , postprocessing	3	1610	January 12, 2023
Regression on 8 of November 2021 - was the CDN version changed? Questions	14	626	January 12, 2022

Pbr custom shader failed to load

Related topics