PG editor templates

roland · October 1, 2024, 4:27am

@Tricotou good ,morning!

Tricotou · October 1, 2024, 7:25am

Seriously ? Do you mean you didn’t have the problem within 2 weeks and today it pops out ? Still happening only on your MacOS I guess ?

roland · October 1, 2024, 8:28am

Exactly.

However this time I was trying to edit an existing PG not starting a new one. Could it be that the existing PG contains some metadata or whatever which has triggered the issue again?

Tricotou · October 1, 2024, 8:33am

Seems unlikely. To me the playground has a unique source code version (from umd) and loads only the code inside the editor from the PG snippets server. But maybe I’m wrong on this.

@RaananW can you confirm that loading an old PG should not load any old code on the PG source code side ?

Also, I make use of this ping to ask about this :
Since a few days, when I load a PG (let’s say https://playground.babylonjs.com/#4U4QH9#9 ) and then I save it, I get this URL : https://playground.babylonjs.com/?BabylonToolkit#4U4QH9#108 containing “BabylonToolkit” by default. Is it the new default behavior ?

++
Tricotou

RaananW · October 1, 2024, 10:31am

You are not wrong. The playground always uses the latest version of babylon, unless you force a specific version or a snapshot

Tricotou · December 9, 2024, 5:26pm

@roland you are not alone anymore, a new user @13th just triggered this on windows. (topic)

Still, I cannot find a specific reproduction pattern

Just a reminder for @RaananW
This topic if about a Monaco Editor bug which triggers sometimes on snippets loaded using replacement fields (${N:field}). This shoud be replaced by autofocus and jump using TAB.
Screencast from 09-12-2024 18:28:43
But sometimes it’s not replaced, and dollar sign pops in the code.
On my side I never had the issue a single time.

On internet I came accross same bug, for example here :

github.com/microsoft/monaco-editor

snippet with replacement fields

opened 09:55AM - 23 Nov 19 UTC

closed 12:38PM - 23 Nov 19 UTC

paillave

I can't find any way to have snippets working with replacement fields I can hav…e snippet that work with no problem, but what I can't have is the replacement field feature. **monaco-editor version:** 0.18.1 **Browser:** Chrome **OS:** Any copy/paste the following code in [the playground](https://microsoft.github.io/monaco-editor/playground.html) ``` csharp function createDependencyProposals() { return [ { label: 'class', kind: monaco.languages.CompletionItemKind.Snippet, documentation: "Class with constructor.", insertText: "public class ${1:MyClass}\n{\n\tprivate int ${2:myProp};\n\tpublic ${1}(int ${2})\n\t{\n\t\tthis.${2} = ${2};\n\t}\n}" }, ]; } monaco.languages.registerCompletionItemProvider('csharp', { provideCompletionItems: function(model, position) { return { suggestions: createDependencyProposals(), }; } }); monaco.editor.create(document.getElementById("container"), { value: `namespace MyNamespace { }`, language: "csharp" }); ``` Ctrl+space -> choose "class" What is inserted is ``` public class ${1:MyClass} { private int ${2:myProp}; public ${1}(int ${2}) { this.${2} = ${2}; } } ``` instead of the following with the possibility to navigate and edit fields `MyClass` and `myProp` ``` public class MyClass { private int myProp; public MyClass(int myProp) { this.myProp = myProp; } } ```

But the answer was :
You’re missing the insertTextRules property
But we do add it :

github.com

BabylonJS/Babylon.js/blob/master/packages/tools/playground/src/tools/monacoManager.ts#L403


      
              this._setupMonacoCompilationPipeline(libContent);

          

              // This is used for a vscode-like color preview for ColorX types

              this._setupMonacoColorProvider();

          

              if (initialCall) {

                  // enhance templates with extra properties

                  for (const template of this._templates) {

                      template.kind = monaco.languages.CompletionItemKind.Snippet;

                      template.sortText = "!" + template.label; // make sure templates are on top of the completion window

                      template.insertTextRules = monaco.languages.CompletionItemInsertTextRule.InsertAsSnippet;

                  }

          

                  this._hookMonacoCompletionProvider();

              }

          

              if (!this.globalState.loadingCodeInProgress) {

                  this._setDefaultContent();

              }

          }

Or maybe there is a problem with initialCall

roland · December 14, 2024, 10:19am

Hey!

Just right now

Topic		Replies	Views
PG is not loaded :( Bugs	17	602	June 10, 2020
Bjs Playground not loading or saving large pgs Questions	13	843	October 7, 2019
Replacing deprecated PG code automatically Feature requests	7	516	February 21, 2022
GUI Documentation: example playground broken Bugs	2	166	December 18, 2023
GUI Editor Bug :: Parse from snippet with external image from dropbox (svg) Bugs gui	11	631	January 23, 2023

PG editor templates

Related topics