Problem excluding everything out of glow layer by default

Questions
1

Hi everyone!

Quick question; I have an issue where I would like to exclude everything from the glow layer by default, and manually add things to it in need basis. Yes, I know there are the inclusion and exclusion arrays. They are not sufficient in this case, since I am making a non static scene (game), where things appear dynamically. Currently, I only want to use the glow layer for one of my solid particle node material, but it propagates to other meshes as well. And marking all the other meshes as excluded would be more tedious than marking them included. I would like to manually mark each of my particle meshes as included, but there is still the problem with 0 particles; this means all the other random stuff might get the glow feature enabled :frowning: And my particle systems are also created on need basis :sweat_smile:

Any ideas what to do with this? A simple boolean for the glow layer like `excludeEverythingByDefault` or something would be nice? :slight_smile:

2

Do you want to do a PR for it ?

1 Like
3

Would certainly like to try! Gonna take some time to learn how to contribute to the repo though :cowboy_hat_face:

1 Like
4

The best guide is there Babylon.js docs

1 Like
5

I’m struggling a bit to get the playgrounds working locally, even a simplest playground like asd | Babylon.js Playground does not load, but the default one does work and some older examples as well… The new ones get Uncaught (in promise) SyntaxError: Unexpected token ‘:’ in the code eval :scream:

Will look into it more if it is on my end tomorrow… I think I managed to code the fix in though :smiling_face_with_sunglasses:

1 Like
7

PR Merged, thanks a lot for the contrib

1 Like
8

Thank you for reviewing it :smiling_face_with_sunglasses: Pretty nice that I have the dev environment set up now as well so I can do contributions easily in the future too!

1 Like
9

Issue fixed in [GlowLayer] Add an option to set all meshes excluded from the glow layer by panuchka · Pull Request #17581 · BabylonJS/Babylon.js

1 Like