Stencil buffer set wrong in highlightlayer excluded meshes after render

tanpopo · April 13, 2023, 1:58am

Bug reproduce: https://playground.babylonjs.com/#K11VKJ#1

BabylonJS/Babylon.js/blob/4f4d3131a9886160508fabac118abb52e66de738/packages/dev/core/src/Layers/highlightLayer.ts#L634


      
              }

          

              const meshExcluded = this._excludedMeshes[mesh.uniqueId];

              if (!meshExcluded) {

                  this._excludedMeshes[mesh.uniqueId] = {

                      mesh: mesh,

                      beforeBind: mesh.onBeforeBindObservable.add((mesh: Mesh) => {

                          mesh.getEngine().setStencilBuffer(false);

                      }),

                      afterRender: mesh.onAfterRenderObservable.add((mesh: Mesh) => {

                          mesh.getEngine().setStencilBuffer(true);

                      }),

                  };

              }

          }

          

          /**

           * Remove a mesh from the exclusion list to let it impact or being impacted by the highlight layer.

           * @param mesh The mesh to highlight

           */

          public removeExcludedMesh(mesh: Mesh) {

StencilBuffer should be set to the previous state in beforeBind rather than true.

Evgeni_Popov · April 13, 2023, 10:37am

Thanks for the report and the fix!

Here’s the PR:

Topic		Replies	Views
Stencil buffer set wrong in effectRenderer Bugs	3	314	July 28, 2023
Highlight Layer fills color when behind partially transparent meshes Bugs 420-alpha27	7	891	August 2, 2020
Highlight layer issues with excluded meshes Bugs	6	775	November 17, 2021
HighlightLayer does not stack properly with translucent material Questions material , highlightlayer	12	615	January 30, 2023
Highlightlayer covering whole mesh Questions	5	957	November 20, 2019

Stencil buffer set wrong in highlightlayer excluded meshes after render

Related topics