I just updated today from 5.4.0 to version 5.21.0 and I noticed that SVG files loaded and base64 hardcoded in the pass stopped working and now only the red and black checker is showing up instead.
We also noticed a similar issue. The loaded SVG and then placed on canvas were also not showing up on texture. I will try to make a PG tomorrow to see if the fix that you just rolled in will cover this issue under FF as well.
Playground with version 5.21.0 works but my local files are still not working. As I checked the package.json file I was installing version 5.21.0 and now on npm there are no new versions available:
So when the new fixed 5.21.1 or something version with this fix will be available on npm?
So today after installing 5.22.0 my storybook exploded with this error:
ERROR in ./node_modules/@babylonjs/core/Materials/Textures/Procedurals/noiseProceduralTexture.js 101:43
Module parse failed: Unexpected token (101:43)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| texture.persistence = parsedTexture.persistence;
| texture.animationSpeedFactor = parsedTexture.animationSpeedFactor;
> texture.time = parsedTexture.time ?? 0;
| return texture;
| }
@ ./node_modules/@babylonjs/core/Materials/Textures/Procedurals/index.js 2:0-44 2:0-44
@ ./node_modules/@babylonjs/core/Materials/Textures/index.js
[...]
What you can do is add another step to transpile the moden js to es5. I wonder if it is realted to an old version of storybook, or if there really is an issue with webpack in general. we have moved to a more modern flavor of js (which your rollup will have no issue with)
I made sure our module test (which is also using webpack) runs correctly - it seems like the latest webpack does work correctly. what version of storybook are you using in your project? if it is using webpack 4 you will need to add a babel step to its webpack configuration
I have no idea why you can’t run it at all, but I would recommend you to do your best to get it to work with webpack 5. Webpack 4 is very old. the last 4 version was released 2 years ago, and it hasn’t updated since.
I agree that it doesn’t mean it’s bad, but if you can take the time to upgrade your project, i would recommend it. Otherwise, you can add the babel step to your storybook webpack (4)'s configuration:
I have no experience with that, so I won’t be able to help you, but that should solve the issue you are experiencing.