When using a non-square image as a texture, we set the vScale of the texture to the aspect ratio so that the image is not distorted. This all works fine. The issue arises when attempting to rotate the texture with wAng. When doing so, the image is distorted by the non-uniform scaling. Here is a very…

This PR should do what you want: Texture: Add a property to avoid deformations when rotating the texture and us… BabylonJS:master ← Popov72:fix-texture-matrixtransform opened 12:06PM - 29 Sep 20 UTC (UTC) …

Yes, thank you. Do you see the distortion when rotating the texture in the playground?

Yes I do see it, it probably comes from the way the transformation matrix is computed here: BabylonJS/Babylon.js/blob/master/src/Materials/Textures/texture.ts#L432-L507 private _prepareRowForTextureGeneration(x: number, y: number, z: number, t: Vector3): void { x *= this._cachedUScal…

I guess it is sort of expected but not a desirable one :frowning: I let @Deltakosh weight on it as this could be a back compat killer.

How can we fix that without breaking back compat ? This is really central for our way of rendering textures so not an easy one (unless we hide it under a flag)

It is unlikely that someone in the past has actually desired that distortion, right? prepareRowForTextureGeneration seems to be around the correct area where the issue is and perhaps it involves some interpolation between the u and v scale as the rotation changes?

I’m happy to review any PR if you want to give it a try

I already attempted the interpolation and found no vScale can be applied to fix the distortion (as seen in the playground when adjusting the vScale). That’s why I created the bug report, because I couldn’t find any corrective action to take on my end.

Conceptually, if you look at uOffset and vOffset, they both follow the axis of rotation (after wAng changes, the offset axes also rotate). Then, with uScale and vScale, they exhibit different behavior where the axes don’t update with rotation changes.

Yeah I feel this is maybe something where we want to rotate on wAng at then end?

Texture rotation not working for non-square images

Bugs

Evgeni_Popov September 27, 2020, 10:54pm 2

Waiting for inputs from @sebavan or @Deltakosh to know if we should create an issue in the repo or if it is the expected behaviour.

uScale and vScale don't rotate with wAng

Topic		Replies	Views
uScale and vScale don't rotate with wAng Questions material	2	725	September 28, 2020
Unable to rotate texture only for selected areas Questions material	4	411	June 9, 2023
Rotate image texture Questions	8	4235	April 29, 2020
Texture transformation order Questions	4	338	May 7, 2020
Material mapping texture rotation does not take effect Questions material	2	288	February 18, 2024

Texture rotation not working for non-square images

Related topics