Texture.updateURL should accept ImageBitmap

heuristics7 · January 30, 2023, 5:02pm

I think this is a pretty minor request as Texture’s _buffer field already can be an ImageBitmap.

BabylonJS/Babylon.js/blob/bfa20f461fc7fa563b03260def05b6e4b9659ef5/packages/dev/core/src/Materials/Textures/texture.ts#L307


      
          private _cachedHomogeneousRotationInUVTransform: boolean = false;

          

          private _cachedReflectionTextureMatrix: Nullable<Matrix> = null;

          private _cachedReflectionUOffset = -1;

          private _cachedReflectionVOffset = -1;

          private _cachedReflectionUScale = 0;

          private _cachedReflectionVScale = 0;

          private _cachedReflectionCoordinatesMode = -1;

          

          /** @internal */

          public _buffer: Nullable<string | ArrayBuffer | ArrayBufferView | HTMLImageElement | Blob | ImageBitmap> = null;

          private _deleteBuffer: boolean = false;

          protected _format: Nullable<number> = null;

          private _delayedOnLoad: Nullable<() => void> = null;

          private _delayedOnError: Nullable<() => void> = null;

          private _mimeType?: string;

          private _loaderOptions?: any;

          private _creationFlags?: number;

          private _useSRGBBuffer?: boolean;

          private _forcedExtension?: string;

github.com

BabylonJS/Babylon.js/blob/bfa20f461fc7fa563b03260def05b6e4b9659ef5/packages/dev/core/src/Materials/Textures/texture.ts#L536


      
              }

          }

          

          /**

           * Update the url (and optional buffer) of this texture if url was null during construction.

           * @param url the url of the texture

           * @param buffer the buffer of the texture (defaults to null)

           * @param onLoad callback called when the texture is loaded  (defaults to null)

           * @param forcedExtension defines the extension to use to pick the right loader

           */

          public updateURL(url: string, buffer: Nullable<string | ArrayBuffer | ArrayBufferView | HTMLImageElement | Blob> = null, onLoad?: () => void, forcedExtension?: string): void {

              if (this.url) {

                  this.releaseInternalTexture();

                  this.getScene()!.markAllMaterialsAsDirty(Constants.MATERIAL_TextureDirtyFlag);

              }

          

              if (!this.name || this.name.startsWith("data:")) {

                  this.name = url;

              }

              this.url = url;

              this._buffer = buffer;

Here’s a quick playground that shows that it should work

Evgeni_Popov · January 30, 2023, 5:28pm

You’re right and it was an easy one!