Unprotected access to `window` in thin engine

nekochanoide · August 6, 2021, 11:03am

Offscreen canvas demo does not work either.
https://www.babylonjs.com/demos/offscreen/

See

nekochanoide · August 6, 2021, 11:04am

‘bag’ typo not intentional :^)

nekochanoide · August 6, 2021, 12:13pm

Ok. Found something.
Using AdvancedDynamicTexture with TextBlock leads to calling ThinEngine.getFontOffset(), which uses document.

github.com

BabylonJS/Babylon.js/blob/d52e8b8a8b3a8b72246bd4db811d160383c22a13/src/Engines/thinEngine.ts#L5114-L5143

    
      
          public getFontOffset(font: string): { ascent: number, height: number, descent: number } {

              var text = document.createElement("span");

              text.innerHTML = "Hg";

              text.setAttribute('style', `font: ${font} !important`);

          

              var block = document.createElement("div");

              block.style.display = "inline-block";

              block.style.width = "1px";

              block.style.height = "0px";

              block.style.verticalAlign = "bottom";

          

              var div = document.createElement("div");

              div.style.whiteSpace = "nowrap";

              div.appendChild(text);

              div.appendChild(block);

          

              document.body.appendChild(div);

          

              var fontAscent = 0;

              var fontHeight = 0;

This file has been truncated. show original

@RaananW @Evgeni_Popov pls check

RaananW · August 6, 2021, 12:47pm

The GUI lib is not supported outside of a browser context. GUI elements require the canvas context as well. There is sadly no way around it.

What you can do is override the function that calls this (Control._GetFontOffset) but then you won’t have font support

nekochanoide · August 6, 2021, 12:51pm

Then PR is ready to merge.

Topic		Replies	Views
Offscreen canvas issue - document is not defined Bugs	6	839	August 23, 2021
Invalid engine. Unable to create a canvas Bugs	18	1917	October 26, 2022
How to hide Babylon canvas and show it again Questions	1	431	November 21, 2021
Proposal for font support in Web Workers Feature requests gui , offscreencanvas	3	326	November 7, 2022
BJS 5.0.37-alpha GUI error Bugs	13	500	August 5, 2021

Unprotected access to `window` in thin engine

Related Topics