Looking at the commits I think there is some confusion here. In the code keysLeft, keysRight, keysUp and keysDown were probably originally named after the specific keys on the keyboard, ie the left, right, up and down arrows, not the direction the camera moves. So we do have keysUp are those moving the camera forward, in the z direction, keysDown are those moving the camera backwards, in the -z direction. What I think @PetterG wants to add are an arrays of keys that move the camera in the y and -y direction. So perhaps a better system might have been keysForward, (z) keysBackward, (-z) keysLeft, (-x) keysRight, (x) keyUp (y) and keysDown (-y) however for backward compatibility this renaming is not possible.
1st - Thanks for the PR, we always appreciate participation from the wonderful community.
4.1 release is right around the corner. We are in code freeze and apart from bug fixes, no new code is being merged.
I do understand what you were trying to achieve - movement in all 3 Axis - left-right in X, up-down (keyboard up-down) in Z and another keyset for the Y axis. It is just the wrong time right now.
Damn, I really needed this feature. It’s quite a pain to rewrite this in the client side. Especially with typescript. Now I have to wait for like a year for BabylonJS 4.2.
Another issue with keys for +Y and -Y, what are the natural default keys? The up arrow key and down arrow key lie naturally in the horizontal plane of the keyboard and indicate movement in the +Z and -Z directions, similarly for the left and right arrow keys.
Possible candidates could be < and > as they do appear to give some indication of direction???
This is an indication for you to go ahead with submitting a PR, taking into account advice from @Deltakosh on naming and default keys. Use a link to above post when submitting.