Breaking change in 5.1 typings

Questions
1

I don’t know if you’d rather fix the typings or remove the backwards compatibility:
I’ve included attachControl from the typings, since they are correct.
image

If think detachControl() had required param till 4.1. Anyway, somehow that param (or the overloaded method) got removed from the typings - it does not look intentional or the comment and property would be gone! :smile: This breaking change is relatively new…

2

cc @RaananW

3

This parameter has been gone for quite some time, and it seems like typescript removes it during compilation for some odd reason. Might be a new ts “feature”.

This is the fix - Fixing typings for camera detachControl by RaananW · Pull Request #12372 · BabylonJS/Babylon.js (github.com)

Typescript removes the last headers for some odd reason (which was unrelated to the eslint comment).

1 Like