Cloned Light doesn't Receive its Assigned Name

labris · November 30, 2021, 10:52pm

Repro: Babylon.js Playground
As one may see, all cloned lights have the same name (the name of the light from which they are cloned).

Solution (tested and works in local environment):
Add to the light.ts (after line 590) the same condition for the name as for the newParent

        if (name) {
            clonedLight.name = name;
        }

github.com

BabylonJS/Babylon.js/blob/master/src/Lights/light.ts#L584

    
      
          public getScaledIntensity() {

              return this._photometricScale * this.intensity;

          }

          

          /**

           * Returns a new Light object, named "name", from the current one.

           * @param name The name of the cloned light

           * @param newParent The parent of this light, if it has one

           * @returns the new created light

           */

          public clone(name: string, newParent: Nullable<Node> = null): Nullable<Light> {

              let constructor = Light.GetConstructorFromName(this.getTypeID(), name, this.getScene());

          

              if (!constructor) {

                  return null;

              }

              let clonedLight = SerializationHelper.Clone(constructor, this);

              if (newParent) {

                  clonedLight.parent = newParent;

              }

              clonedLight.setEnabled(this.isEnabled());

Should I make a PR?

Deltakosh · November 30, 2021, 11:54pm

Please do
Highly appreciated!

labris · December 1, 2021, 3:23am

PR made!

UPD. Merged, so I mark this as solution

UPD 2. It works

Topic		Replies	Views
Wrong name assigned to a cloned camera Bugs	1	343	September 13, 2021
Possible bug cloning lights imported via SceneLoader.LoadAssetContainer Bugs lighting	4	570	May 5, 2020
Transform And Mesh Cloning Child Names Questions	4	1174	July 24, 2023
Default Mesh Instance Naming Format Question? Questions	1	310	January 27, 2020
Invoke Clone with camera childNode can not keep structure Bugs node	2	496	April 26, 2022

Cloned Light doesn't Receive its Assigned Name

Related topics