Dead code in GLTFMaterialExporter

Questions
1

Hi,
The _convertPBRMetallicRoughnessMaterialAsync function in GTLFMaterialExporter is not used anymore, as it looks like the same behavior has been applied to PBRMaterials and PBRMetallicRoughnessMaterials in the _convertMaterialsToGLTFAsync function since the 5.0 release.

Sources:

1 Like
2

I totally agree. Let’s just make sure @bghgary agrees as well and I will drop that function

3

Yup, looks dead. How did that happen? :slight_smile:

4

It felt between the cracks :slight_smile:
I’ll remove it

5

Remove dead code by deltakosh · Pull Request #12408 · BabylonJS/Babylon.js (github.com)