Decal not working after PR requests is merged

vijay_krishna · October 20, 2022, 11:20am

Hi,

Recently @Evgeni_Popov merged the request regarding decals
Currently existing code snippets are not working,

github.com/BabylonJS/Babylon.js

Decals: Add support for rigged meshes + optimization for speed

BabylonJS:master ← Popov72:decal-support-rigged

opened 09:52PM - 13 Oct 22 UTC

Popov72

+316 -62

See https://forum.babylonjs.com/t/decals-are-not-supported-for-glb-files/34571/2…1 The doc has also been updated (https://github.com/BabylonJS/Documentation/pull/673). I have tried to remove a number of object creations (`Vector3` / `Vector4`) to lower GC pressure, at least in the main paths. Also, to avoid over-complicating the code even more, I handle only the first 4 matrix indices/weights of a rigged mesh when creating new vertices at the clipping stage (vertices that are not clipped retain their full indices/weights). I did not see any artefacts because of that in my testings. This code can be revisited later if necessary.

could u pls have a look

Thanks
vijay

vijay_krishna · October 20, 2022, 12:38pm

Just to add detail insight, the PR was working till yesterday i.e we were able to apply decals to the mesh.
From today onwards its not working

sebavan · October 20, 2022, 3:10pm

cc @Evgeni_Popov about the PR

Evgeni_Popov · October 21, 2022, 9:49am

This PR fixed it and is now deployed in the Playground.

Topic		Replies	Views
Decal not showing on imported mesh Questions	5	304	January 30, 2023
Decals are not supported for glb files Questions material	28	2143	October 14, 2022
Decal draw calls Questions	9	804	November 11, 2022
Unable to use decal textures Questions playground , coding , decals	1	253	July 4, 2023
Warning logged when disposing a decal Bugs	3	374	October 10, 2022

Decal not working after PR requests is merged

Related Topics