Docs: Coming next – links are div elements

Bugs
1

Hello documentation team,

( @RaananW and @PirateJC, I guess, and everybody else who cares :innocent: )

Just found out that the cards in the “Coming next” section of the docs (random example: Shaders | Babylon.js Documentation) are all plain div elements. Noticed when I tried to open one in a new tab. Bummer.

I checked the SingleBucketItem component, but it looks pretty unsuspicious:

<Link key={link} href={link}> …

I couldn’t find anything in the next.js docs, did some searching but I’m still pretty clueless what could be the problem. Haven’t worked with next.js so far, but this behaviour seems very strange.

Could somebody please take a look at this, or pinpoint me in the right direction?

Thanks a lot already

3 Likes
2

Hey @panepeter , I never noticed you can’t open in a new tab. It should be covered by next (and should be wrapped by an “a” element). I’ll check and fix it.

Thanks!

2 Likes
4

This addresses the issue - will be merged shortly

bucket items are now wrapped in anchor by RaananW · Pull Request #400 · BabylonJS/Documentation (github.com)

2 Likes
6

Looks good @RaananW, thanks for taking care of it :pray:

After taking another look into the nextjs docs, it seems pretty obvious now that the <a> was missing :see_no_evil:

I can only blame my blindness on my Gatsby background, where you just put a <Link>, and that renders an <a> for you by default. Seems a bite more straightforward. I’ll still take a closer look at nextjs at some point …

1 Like