`Effect._checkIsReady` infinite loop when dispose scene with DefaultRenderingPipeline

Bugs
1

The code to reproduce the bug is very short.

const canvas = document.createElement("canvas");
const engine = new Engine(canvas);
const scene = new Scene(engine);
new DefaultRenderingPipeline("default", true, scene);

scene.dispose();
engine.dispose();

After running the above code, the infinite setTimeout loop will run.
image

Here is the repository to reproduce the bug. I’ve kept the things minimal.

If you dispose the engine and scene immediately after creating them, the effect will wait indefinitely for shader compilation.

However, without DefaultRenderingPipeline, this bug does not occur. :roll_eyes:

The bug seems to be related to this issue.

2 Likes
`Effect._checkIsReady` infinite loop when dispose scene with DefaultRenderingPipeline again
2

Let me check that :slight_smile:

2 Likes
3

here we are:
Fix effect dispose memory leak by deltakosh · Pull Request #15294 · BabylonJS/Babylon.js (github.com)

2 Likes
4

Thank you always :slightly_smiling_face: :slightly_smiling_face: :slightly_smiling_face:

1 Like