Hardcoded #include replacements in PBRCustomMaterial constructor

slin · September 24, 2023, 7:31pm

Happy weekend!

I have a question about PBRCustomMaterial implementation. Why does the constructor has 3 statements to explicitly replace shader includes? PBR shader contains many includes, why these specific 3 only? Can’t these includes be replaced centrally by ShaderProcessor._ProcessIncludes?

github.com

BabylonJS/Babylon.js/blob/master/packages/dev/materials/src/custom/pbrCustomMaterial.ts#L223


      
          }

          

          constructor(name: string, scene?: Scene) {

              super(name, scene);

              this.CustomParts = new ShaderAlebdoParts();

              this.customShaderNameResolve = this.Builder;

          

              this.FragmentShader = Effect.ShadersStore["pbrPixelShader"];

              this.VertexShader = Effect.ShadersStore["pbrVertexShader"];

          

              this.FragmentShader = this.FragmentShader.replace(/#include<pbrBlockAlbedoOpacity>/g, Effect.IncludesShadersStore["pbrBlockAlbedoOpacity"]);

              this.FragmentShader = this.FragmentShader.replace(/#include<pbrBlockReflectivity>/g, Effect.IncludesShadersStore["pbrBlockReflectivity"]);

              this.FragmentShader = this.FragmentShader.replace(/#include<pbrBlockFinalColorComposition>/g, Effect.IncludesShadersStore["pbrBlockFinalColorComposition"]);

          }

          

          public AddUniform(name: string, kind: string, param: any): PBRCustomMaterial {

              if (!this._customUniform) {

                  this._customUniform = new Array();

                  this._newUniforms = new Array();

                  this._newSamplerInstances = {};

                  this._newUniformInstances = {};

Evgeni_Popov · September 25, 2023, 9:03am

These includes are explicitely replaced by their code because they contain some #define CUSTOM_XXX declarations and the PBRCustomMaterial class requires that these defines are in the main shader code flow to be able to replace them by your custom code.

slin · September 25, 2023, 2:19pm

Thanks @Evgeni_Popov. Now I got it. All the CUSTOM_XXX defines are replaced in the customShaderNameResolve implementation within PBRCustomMaterial.

Topic		Replies	Views
New PBR Shader Breaking Changes Questions	7	968	December 21, 2020
When I use PBRCustomMaterial , what if I can guarantee that all the properties of the original PBR material on the model will be assigned to PBRCustomMaterial? Questions material	6	32	November 25, 2024
Shader includes and threeshaking Questions	2	576	September 26, 2022
PBRCustomMaterial (or PBRMaterial) with custom albedo and normal Questions	7	1105	April 25, 2021
Making the base material shader customizable Feature requests	2	300	November 8, 2021

Hardcoded #include replacements in PBRCustomMaterial constructor

Related topics