Is instanceof false after the GaussianSplattingMesh is cloned?

rookiewxy · July 23, 2024, 3:30am

Why is instanceof false After GaussianSplattingMesh is cloned?

Tricotou · July 23, 2024, 10:16am

The GaussianSplattingMesh inherits from Mesh class.
Having a look at the source code, I can see that indeed, it does not override the clone method resulting in returning a Mesh instance. While for example the GreadedLine does override, returning the right class.

Maybe it’s like so for some reasons… Let’s wait for the official devs to have a look
I think @Cedric was the last dev to work on splats clone in this PR

Deltakosh · July 23, 2024, 2:33pm

please be patient as @Cedric is out on vacation

Cedric · August 12, 2024, 1:12pm

github.com

BabylonJS/Babylon.js/blob/11537810d961231017e0f9ad1fe027290526e47a/packages/dev/core/src/Meshes/GaussianSplatting/gaussianSplattingMesh.ts#L346


      
              this._covariancesBTexture = source.covariancesBTexture?.clone()!;

              this._centersTexture = source.centersTexture?.clone()!;

              this._colorsTexture = source.colorsTexture?.clone()!;

          }

          

          /**

           * Returns a new Mesh object generated from the current mesh properties.

           * @param name is a string, the name given to the new mesh

           * @returns a new Gaussian Splatting Mesh

           */

          public override clone(name: string = ""): GaussianSplattingMesh {

              const newGS = new GaussianSplattingMesh(name, undefined, this.getScene());

              newGS._copySource(this);

              newGS.makeGeometryUnique();

              newGS._vertexCount = this._vertexCount;

              newGS._copyTextures(this);

              newGS._modelViewMatrix = Matrix.Identity();

              newGS._splatPositions = this._splatPositions;

              newGS._instanciateWorker();

          

              const binfo = this.getBoundingInfo();

Cedric · August 12, 2024, 1:14pm

A Gaussian Splatting mesh can not be instanced like a classic mesh. The main reason is because of sorting each splat individually (back to front) with a webworker. So, many datas need to be duplicated and adapted for each clone. I have no doubt this will be changed in the future with webGPU. But until then …

Topic		Replies	Views
Instances vs. Clones Questions	10	2960	May 7, 2020
GridMaterial GaussiansplattingMesh.clone() Bugs material	2	100	February 29, 2024
GaussianSplattingMesh clone() Bugs	4	68	June 6, 2024
CheckCollisions can't be used with createInstance() method? Questions	10	952	September 12, 2022
Any way to keep gl_InstanceID the same? Questions	1	274	August 14, 2022

Is instanceof false after the GaussianSplattingMesh is cloned?

Related topics