Issue with babylonjs/core package and UniversalCamera

PichouPichou · April 26, 2019, 10:40pm

I have this error showing when creating a new UniversalCamera:
_this.inputs.addGamepad is not a function.

And indeed there is no addGamepad function if I go to the files

BabylonJS/Babylon.js/blob/master/src/Cameras/freeCameraInputsManager.ts

import { FreeCamera } from "./freeCamera";
import { CameraInputsManager } from "./cameraInputsManager";
import { FreeCameraKeyboardMoveInput } from "../Cameras/Inputs/freeCameraKeyboardMoveInput";
import { FreeCameraMouseInput } from "../Cameras/Inputs/freeCameraMouseInput";
import { FreeCameraTouchInput } from "../Cameras/Inputs/freeCameraTouchInput";
import { Nullable } from '../types';

/**
 * Default Inputs manager for the FreeCamera.
 * It groups all the default supported inputs for ease of use.
 * @see http://doc.babylonjs.com/how_to/customizing_camera_inputs
 */
export class FreeCameraInputsManager extends CameraInputsManager<FreeCamera> {
    /**
     * @hidden
     */
    public _mouseInput: Nullable<FreeCameraMouseInput> = null;
    /**
     * Instantiates a new FreeCameraInputsManager.
     * @param camera Defines the camera the inputs belong to

This file has been truncated. show original

github.com

BabylonJS/Babylon.js/blob/master/src/Cameras/cameraInputsManager.ts

import { Logger } from "../Misc/logger";
import { SerializationHelper } from "../Misc/decorators";
import { Nullable } from "../types";
import { Camera } from "./camera";
/**
 * @ignore
 * This is a list of all the different input types that are available in the application.
 * Fo instance: ArcRotateCameraGamepadInput...
 */
export var CameraInputTypes = {};

/**
 * This is the contract to implement in order to create a new input class.
 * Inputs are dealing with listening to user actions and moving the camera accordingly.
 */
export interface ICameraInput<TCamera extends Camera> {
    /**
     * Defines the camera the input is attached to.
     */
    camera: Nullable<TCamera>;

This file has been truncated. show original

I had no issue with classic babylonjs packages.

Deltakosh · April 26, 2019, 10:43pm

Yep this is because of the TreeShacking. You need to import the Gamepad module

PichouPichou · April 26, 2019, 10:47pm

Ok so I have to make sure myself that all the modules needed are loaded. Understood!

But I wonder why UniversalCamera doesn’t load the Gamepad module then if it needs it?
Something linked to the backward compatibility as you mentionned in the documentation?

Deltakosh · April 26, 2019, 10:47pm

Nope this is actually a problem
Pinging @sebavan

Deltakosh · April 26, 2019, 10:54pm

In the meantime, you have the list of components here:
https://doc.babylonjs.com/features/es6_support#faq

PichouPichou · April 26, 2019, 10:57pm

I imported the gamepad module but it doesn’t change anything.
import { Gamepad } from '@babylonjs/core/Gamepads/gamepad'

Here is an online repo: Hardwino Explanation

Deltakosh · April 26, 2019, 11:04pm

Yep I found the issue
will be on the next nightly (in a hour or so)

PichouPichou · April 26, 2019, 11:05pm

Thanks, I will test it tomorrow and keep you in touch.

PichouPichou · April 27, 2019, 8:18am

Hi @Deltakosh, how do I test the nightly update?

I realized i could simply use a freeCamera instead of the Universal. But then I have another similar error showing when I create new DefaultRenderingPipeline:
this._scene.enableDepthRenderer is not a function

And I can’t find that function in the babylonjs code in order to import it.

PichouPichou · April 27, 2019, 9:25am

I found it here and now it works: Babylon.js/depthRendererSceneComponent.ts at master · BabylonJS/Babylon.js · GitHub

PichouPichou · April 27, 2019, 10:30am

Verdict on treeshaking: I went from a little more than 3MB to a little less than 2MB! Awesome!

Deltakosh · April 27, 2019, 12:47pm

this is gooood!

PichouPichou · May 8, 2019, 4:44pm

It seems that there is also a missing import with shadowGenerator:
“shadowGenerator.ts:719 Uncaught ShadowGeneratorSceneComponent needs to be imported before as it contains a side-effect required by your code.”

I made it myself for now.

inteja · March 16, 2020, 2:23am

@PichouPichou how did you resolve this? I’m getting the same issue.

RaananW · March 16, 2020, 7:24am

Are you referring to the shadow generator error? Make sure the needed classes are imported.

inteja · March 16, 2020, 7:27am

@RaananW I worked it out thanks. See related topic Production build error "ShadowGeneratorSceneComponent needs to be imported"

PichouPichou · March 16, 2020, 8:07am

You will find all the imports needed using ecma script here: ES6 - Babylon.js Documentation

Topic		Replies	Views
Mouse camera input bug Questions	7	643	July 22, 2021
BabylonJS Documentation's example error Bugs documentation	7	564	October 25, 2019
Change FreeCamera to UniversalCamera Feature requests camera	3	709	February 2, 2021
Gamepad Controller Questions arcrotatecamera , gamepad , arcrotatecamerainput , arcrotatecameragamep	11	1376	January 3, 2024
Looking for the keyboard control method for UniversalCamera Questions	4	453	June 18, 2021

Issue with babylonjs/core package and UniversalCamera

Related topics