Matrix.LookAtLHToRef not returning

kzhsw · November 17, 2023, 8:50am

The doc here says it returns result input, but this method does not have a return statement.

BabylonJS/Babylon.js/blob/928734227f127afe4fbf5a6f98c59d0432f8063b/packages/dev/core/src/Maths/math.vector.ts#L6833


      
          

          /**

           * Sets the given "result" Matrix to a matrix that transforms vertices from world space to camera space. It takes three vectors as arguments that together describe the position and orientation of the camera.

           * This function generates a matrix suitable for a left handed coordinate system

           * Example Playground - https://playground.babylonjs.com/#AV9X17#60

           * Example Playground - https://playground.babylonjs.com/#AV9X17#61

           * @param eye defines the final position of the entity

           * @param target defines where the entity should look at

           * @param up defines the up vector for the entity

           * @param result defines the target matrix

           * @returns result input

           */

          public static LookAtLHToRef(eye: DeepImmutable<Vector3>, target: DeepImmutable<Vector3>, up: DeepImmutable<Vector3>, result: Matrix): void {

              const xAxis = MathTmp.Vector3[0];

              const yAxis = MathTmp.Vector3[1];

              const zAxis = MathTmp.Vector3[2];

          

              // Z axis

              target.subtractToRef(eye, zAxis);

              zAxis.normalize();

github.com

BabylonJS/Babylon.js/blob/928734227f127afe4fbf5a6f98c59d0432f8063b/packages/dev/core/src/Maths/math.vector.ts#L6863


      
          

              // Y axis

              Vector3.CrossToRef(zAxis, xAxis, yAxis);

              yAxis.normalize();

          

              // Eye angles

              const ex = -Vector3.Dot(xAxis, eye);

              const ey = -Vector3.Dot(yAxis, eye);

              const ez = -Vector3.Dot(zAxis, eye);

          

              Matrix.FromValuesToRef(xAxis._x, yAxis._x, zAxis._x, 0.0, xAxis._y, yAxis._y, zAxis._y, 0.0, xAxis._z, yAxis._z, zAxis._z, 0.0, ex, ey, ez, 1.0, result);

          }

          

          /**

           * Creates a new matrix that transforms vertices from world space to camera space. It takes three vectors as arguments that together describe the position and orientation of the camera.

           * This function generates a matrix suitable for a right handed coordinate system

           * Example Playground - https://playground.babylonjs.com/#AV9X17#62

           * Example Playground - https://playground.babylonjs.com/#AV9X17#63

           * @param eye defines the final position of the entity

           * @param target defines where the entity should look at

           * @param up defines the up vector for the entity

RaananW · November 17, 2023, 10:58am

want to submit a fix?

sebavan · November 20, 2023, 10:36pm

Here it is Usability Fix by sebavan · Pull Request #14532 · BabylonJS/Babylon.js · GitHub

Topic		Replies	Views
Matrix.getRowToRef incorrectly handles 4th row Bugs	2	132	November 28, 2023
Lock Rotation for "lookAt()" Questions	3	1256	August 10, 2020
"FromLookDirectionLH" is a bit too complicated. Maybe a simpler api should be provided? Feature requests quaternion , math	3	299	June 7, 2023
LookAt Cameras Plane vs Position Questions	2	316	August 5, 2023
Comments refer to wrong vectors returned by method using ToRef Bugs api	3	399	September 21, 2022

Matrix.LookAtLHToRef not returning

Related Topics