NME Texture UV Planar Projection

This PR will fix the serialization problem:

As the fact that setting all the neutral blocks to Fragment does not make the code move to the fragment shader matches what I experienced when making the changes “by hand” for testing purposes and we would need to dig a bit further to understand what’s going on.

Thanks a lot!
I guess the issue with the variable name would still exist though, right? The following playground makes use of a third texture sampler and in the process of multiplication with the other two samplers it throws an error, that its variable is used already. It seems similar to the earlier issue with an undefined variable.

@Evgeni_Popov will have a look on Monday as he is off until then :slight_smile:

Thanks! There is no rush! Just wanted to remind, that there is another issue than only serialization :slight_smile:

1 Like

No, this one is corrected. There is no error for me in your PG.

You are right! I guess it was solved in alpha5 :slight_smile: Looking forward to try it out :slight_smile:

1 Like

Tentative PR:

The fix makes https://playground.babylonjs.com/#2SN0M8#6 work once the VectorMerger is set to the Fragment shader but I don’t know if it’s the right fix, waiting for feedbacks.

2 Likes

Hi,
the fix on the VectorMerger seems to work great! If I set it to fragment shader, I also see those changes on the texture block!
But the fragment workflow seems to break the texture conversion into linear color as you can see in the screenshots and playground below. I hope that is not a big deal?

https://playground.babylonjs.com/#ZV809N

This is a bug in the texture block, not related to the target change. Here’s the fix:

2 Likes