Last time I saw the exactly same issue:
1 Like
1 Like
Looking (though from the old thread, it sounds like it was an intermittent GitHub issue)…
From what I can tell, this list is auto generated from the “GitHub Release” Azure DevOps build pipeline task, which internally is calling some GitHub API, so unfortunately I don’t think we have any control over this. I can edit the release to remove the issues that seem to be unrelated, but actually fixing the underlying issue might be out of our hands. 
1 Like
I looked closer at the reference to issue #5 in the release notes for this release, and it looks like this is what happened:
- Sergio had two branches (say BranchA and BranchB) in his own BJS fork
- He created a PR in his own fork to merge BranchB into BranchA
- This created a commit in his fork that referenced PR #5
- He then created a PR of BranchB into the master branch of Babylon.js
- The commit list for this PR included his commit that was for his PR #5 in his own fork
- The GitHub Release pipeline task ran, inspected commits for PRs, and misinterpreted the reference to #5 as a reference to issue #5 within the Babylon.js repo.
I logged a GitHub bug for this, but it seems that only the person that logged the bug can access the bug, so I can’t share a link, but we’ll see what happens!
4 Likes
After the release notes generated, is it possible to fetch and parse it, and filter with conditions:
- is PR, not issue
- is merged
- targeted commit is within range of last release and current
Generating release notes is all part of a single GitHub Release AzureDev ops task. Querying the commits between releases, generating the release notes, and creating the GitHub release with the binaries and release notes is all part of one single task. So I don’t think it would be possible to do something like what you outlined above unless we completely rolled our own GitHub release logic. I think at this point we should monitor the releases and cleanup manually as needed and wait to see if GitHub fixes this bug.
Well, I mean, just let github generate it, and it should be possible to get the release notes via some API, after the release was published.
cc @docEdub
Thanks for reporting this. I removed the invalid entries manually. @ryantrem Any word on the bug report you filed for this?
No update on the bug. I was asked to open a regular GitHub issue after I reported the bug initially though, which you can see here: [BUG]: GitHubReleaseV1: Auto-generated release notes can reference incorrect issues · Issue #21112 · microsoft/azure-pipelines-tasks
1 Like
@ryantrem anything we can do on our side? This is pretty bad
I’m not sure there is anything we can do unless we want to implement our own custom release notes generator…
maybe ping some folks at github?
Switching from “Issue based” changelogs to “Commit based” may avoid this issue.
I think this will change the link in the changelog to the commit instead of the PR, but the commit has the link to the PR, so it’s not a huge difference. Just one extra click to get to the PR.
1 Like
I think I found someone and pinged them, I’ll see if I can get any info!
1 Like
Fixed. Thanks again for the heads up!
1 Like