postProcess indices reversed after disable and enable renderEffect

tanpopo · August 3, 2023, 2:23am

PG: https://playground.babylonjs.com/#YKD6LT#1
Before uncommented line 24-25, blackAndWhite postprocess renders before blur process, but after disable and enable the effect, blackAndWhite postprocess renders after blur postprocess.

I believe it is a bug in these lines as foreach should not be used:

github.com

BabylonJS/Babylon.js/blob/f6659302ec5c6ac728855875f58c1e72b4ffd4e4/packages/dev/core/src/PostProcesses/RenderPipeline/postProcessRenderEffect.ts#L203


      
              if (!cams) {

                  return;

              }

          

              for (let i = 0; i < cams.length; i++) {

                  const camera = cams[i];

                  const cameraName = camera.name;

          

                  for (let j = 0; j < this._indicesForCamera[cameraName].length; j++) {

                      if (camera._postProcesses[this._indicesForCamera[cameraName][j]] === undefined || camera._postProcesses[this._indicesForCamera[cameraName][j]] === null) {

                          this._postProcesses[this._singleInstance ? 0 : cameraName].forEach((postProcess) => {

                              cams![i].attachPostProcess(postProcess, this._indicesForCamera[cameraName][j]);

                          });

                      }

                  }

              }

          }

          

          /**

           * Disables the effect on the given cameras

           * @param cameras The camera to disable.

I think it should be changed to

for (let j = 0; j < this._indicesForCamera[cameraName].length; j++) {
    if (camera._postProcesses[this._indicesForCamera[cameraName][j]] === undefined || camera._postProcesses[this._indicesForCamera[cameraName][j]] === null) {
        cams![i].attachPostProcess(this._postProcesses[j], this._indicesForCamera[cameraName][j]);
    }
}

If not, how can I disable an effect?

Cedric · August 3, 2023, 9:41am

ping @Evgeni_Popov

Evgeni_Popov · August 3, 2023, 11:35am

Thanks for reporting, here’s the fix:

Topic		Replies	Views
Bugs when managing postprocess pipeline Bugs	3	282	August 10, 2023
Disabling and enabling a PostProcessRenderPipeline Questions	3	385	January 17, 2022
Issues in the documentation for PostEffects Questions postprocessing	6	668	September 30, 2022
Video Background Layer Apply Post Process Questions rendering	8	41	October 7, 2024
Post processing does not seem to work correctly when order independent transparency is enabled Bugs	2	543	November 10, 2021

postProcess indices reversed after disable and enable renderEffect

Related topics