`setMaterialForRendering` of `renderTargetTexture` not exist

tanpopo · October 19, 2021, 11:38am

Document link: Render Target Texture With Multiple Passes | Babylon.js Documentation.
I just found the function on the document but failed to find it in source code on master branch as well as the issues nor the PR. I noticed that there is only a PR on the document.

RaananW · October 19, 2021, 12:10pm

@sebavan , any idea here?

sebavan · October 19, 2021, 12:58pm

Yup the PR from @Evgeni_Popov containing the code is coming tonight

Evgeni_Popov · October 19, 2021, 5:17pm

If you want to follow the status:

github.com/BabylonJS/Babylon.js

WebGPU: non compatibility mode implementation (aka "fast path")

BabylonJS:master ← Popov72:webgpu-fastpath

opened 05:14PM - 19 Oct 21 UTC

Popov72

+1233 -494

The implementation is not finished yet but the PR is already quite big, so there… will be another one (normally quite smaller!) to account for the missing bits (the biggest one being adding support for submeshes in `ShaderMaterial`). Some quick numbers before describing the PR: * even if it's a WebGPU PR, some changes also affect WebGL (like the render passes) that improve performances: the JS thread takes between 5% and 20% less time on the PGs I have tested compared to WebGL 4.2 (it's also better than the current WebGL 5.0 code in prod) * WebGPU: * the JS thread takes between 10% and 16% **more** time than in WebGL in the *compatibility mode* (that is, with `engine.compatibilityMode = true`). It's expected, in this mode we have to use a number of caches that slow things down in WebGPU * the JS thread takes between 14% and 20% **less** time than in WebGL in the *non compatibility mode* (that is, with `engine.compatibilityMode = false`, the purpose of the PR) * note that the comparison with WebGL is done against the numbers measured **with** this PR for WebGL, not against the WebGL code currently in prod! Here's an overview of the PR: * I have added render pass ids, which are simply ids that are assigned to each "render pass". Basically, the main render pass (the one rendering the scene into the framebuffer) is always id #0 and each rendering by a `RenderTargetTexture` is using a specific id (or several, if the RTT is a cube or a 2D layer). The id(s) are allocated in the class constructor. This id is used to retrieve the right `DrawWrapper` on the submesh that is currently rendered (those wrappers are stored in the `SubMesh._drawWrappers` array: the index in this array is the render pass id). In WebGPU that allows to have a bundle cached (in `DrawWrapper.drawContext`) for each rendering and reusing it when in the _non compatibility mode_. However, it's also a perf gain in WebGL because the effects are not recreated/retrieved from the engine each time we execute `isReadyForSubMesh` but are retrieved from the `DrawWrapper`. * I'm going to create a doc page about render pass ids and how they allow to use a different material depending on the pass (render target) a mesh is rendered into => see `RenderTargetTexture.setMaterialForRendering` in the current PR, but I have also added this method to the depth renderer (`DepthRender.setMaterialForRendering`). I will also update the `EffectLayer` class with this feature. * Regarding post processes, I needed to know if one is going to overwrite the `textureSampler` texture of the shader. Indeed, the `PostProcess` class (in the `apply` method) is setting the value with the source input value, but some effects were overwriting it just afterward in a `postprocess.onApplyObserver` observer: in WebGPU it kills the bundle cache because it dirtyfies the material context. So, setting `postprocess.externalTextureSamplerBinding = true` instructs the `PostProcess` class to **not** update the value itself because it will be done by some external code. Note it's an optimization (for WebGPU): if you don't do it it still work, but you will have some bundles recreated each frame that could be avoided. * When in fast mode, if using instances, we use an indirect draw to be able to update the instance count without recreating the cached bundle: we simply need to update the buffer holding the draw parameters (and more precisely the instance count parameter)

Topic		Replies	Views
RenderTargetTexture changed? Multipass examples are broken Bugs	2	690	October 20, 2021
RenderTargetTexture - Only render to texture in first pass Questions material	4	555	September 6, 2020
Volumetric Rendering with shader and 2D Textures - multi pass Questions	3	1806	April 30, 2024
RTT with shader material not rendered on first frame Questions render-target , rendering	9	35	February 24, 2025
The results of one shader run are used as texture input for another shader Questions shader	6	381	December 6, 2022

`setMaterialForRendering` of `renderTargetTexture` not exist

Related topics