Circular dependency issue when exporting to Babylon with KHR_materials_variants

tboggs300 · November 21, 2022, 12:05am

Using this model: glTF-Sample-Models/2.0/MaterialsVariantsShoe at master · KhronosGroup/glTF-Sample-Models · GitHub
Circular dependency issue displayed in console for both gltf and glb file versions of the model when exporting to Babylon from the Sandbox.
Any idea why? I was going to start working on adding the KHR_materials_variants export when I ran into this issue.

Evgeni_Popov · November 21, 2022, 9:53am

Welcome aboard!

I think this one is for @bghgary.

bghgary · November 21, 2022, 5:57pm

bghgary · November 30, 2022, 9:34pm

Sorry for the slow response, but I will try to look at this soon. If anyone else wants to investigate, it will be helpful.

Evgeni_Popov · December 1, 2022, 3:08pm

Evgeni_Popov · December 21, 2022, 5:17pm

A PR is on its way:

github.com/BabylonJS/Babylon.js

Add a _internalMetadata to avoid side effects with metadata

BabylonJS:master ← Popov72:mesh-metadata

opened 05:15PM - 21 Dec 22 UTC

Popov72

+47 -38

See https://forum.babylonjs.com/t/circular-dependency-issue-when-exporting-to-ba…bylon-with-khr-materials-variants/35856 The glTF loader used to use `Node.metadata` / `BaseTexture.metadata` / `Material.metadata` for internal use, preventing serialization of corresponding objects in some cases. There is now a new `_internalMetadata` property for `Node` / `BaseTexture` / `Material` for internal use only (this property is not serialized).

Evgeni_Popov · December 21, 2022, 5:17pm

Evgeni_Popov · January 3, 2023, 11:08pm

The PR has now been merged.