debugLayer.onPropertyChangedObservable not firing when enabling / disabling lights

Anupam_Das · July 5, 2023, 8:22pm

debugLayer.onPropertyChangedObservable is not firing when enabling disabling lights in the BJS inspector. wonder if this is a bug or feature? is there another event i can watch when a user enables/disables lighting?

Takemura · July 5, 2023, 9:37pm

The enabled state change of a lightTreeItemComponent

github.com

BabylonJS/Babylon.js/blob/master/packages/dev/inspector/src/components/sceneExplorer/entities/lightTreeItemComponent.tsx#L62


      
                  const isGizmoEnabled =

                      this.state.isGizmoEnabled || (this.props.light && this.props.light.reservedDataStore && this.props.light.reservedDataStore.lightGizmo) ? (

                          <FontAwesomeIcon icon={faEye} />

                      ) : (

                          <FontAwesomeIcon icon={faEye} className="isNotActive" />

                      );

          

                  return (

                      <div className="lightTools">

                          <TreeItemLabelComponent label={this.props.light.name} onClick={() => this.props.onClick()} icon={faLightbulb} color="yellow" />

                          <div className="visibility icon" onClick={() => this.switchIsEnabled()} title="Turn on/off the light">

                              {isEnabledElement}

                          </div>

                          <div className="enableGizmo icon" onClick={() => this.toggleGizmo()} title="Turn on/off the light's gizmo">

                              {isGizmoEnabled}

                          </div>

                          {<ExtensionsComponent target={this.props.light} extensibilityGroups={this.props.extensibilityGroups} />}

                      </div>

                  );

              }

          }

is handled differently than i.e. transform nodes by the inspector, so that it does not trigger/notify onPropertyChanged-observers.

github.com

BabylonJS/Babylon.js/blob/master/packages/dev/inspector/src/components/actionTabs/tabs/propertyGrids/meshes/meshPropertyGridComponent.tsx#L445


      
              lockObject={this.props.lockObject}

              onPropertyChangedObservable={this.props.onPropertyChangedObservable}

          />

          {mesh.skeleton && <TextLineComponent label="Skeleton" value={mesh.skeleton.name} onLink={() => this.onSkeletonLink()} />}

          <CheckBoxLineComponent

              label="Is enabled"

              isSelected={() => mesh.isEnabled()}

              onSelect={(value) => {

                  const prevValue = mesh.isEnabled();

                  mesh.setEnabled(value);

                  this.props.onPropertyChangedObservable?.notifyObservers({

                      object: mesh,

                      property: "isEnabled",

                      value,

                      initialValue: prevValue,

                  });

              }}

          />

          <CheckBoxLineComponent label="Is pickable" target={mesh} propertyName="isPickable" onPropertyChangedObservable={this.props.onPropertyChangedObservable} />

          {mesh.material && (!mesh.material.reservedDataStore || !mesh.material.reservedDataStore.hidden) && (

              <TextLineComponent label="Link to material" value={mesh.material.name} onLink={() => this.onMaterialLink()} />

Maybe our experts @carolhmj @RaananW @sebavan know if it can/should be included.

Currently a possibility is to use onEnabledStateChangedObservable of your lights:

RaananW · July 6, 2023, 11:44am

Makes sense to me to add that (in the right place)
@carolhmj - do you have the time?
If not i’ll take care of that later.

carolhmj · July 6, 2023, 3:47pm

I can do that sure

carolhmj · July 6, 2023, 5:27pm

PR here: [Inspector] When changing relevant properties on the Camera, Light an… by carolhmj · Pull Request #14028 · BabylonJS/Babylon.js (github.com)

Topic		Replies	Views
Inspector: onPropertyChangedObservable Questions	1	655	March 7, 2019
Problems with light stateChangeObservable Questions	4	357	October 29, 2021
debugLayer Observable propertys not work Bugs	5	540	June 25, 2019
Dropdown and others not detected in inspector observable with onPropertyChangedObservable Bugs	2	322	April 11, 2022
DebugLayer on Babylon 3.3 Questions	4	594	March 7, 2019

debugLayer.onPropertyChangedObservable not firing when enabling / disabling lights

Related topics