defaultRenderingPipeline Performance concerns

brightMoon · May 26, 2024, 5:28pm

Will it be a performance issue for the program to destroy existing pipelines and rebuild them all when setting each switch for the default rendering pipeline?

github.com

BabylonJS/Babylon.js/blob/94b1af040b116966181858d3d873c85faf293234/packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/defaultRenderingPipeline.ts#L597


      
          private _activeCamerasChangedObserver: Nullable<Observer<Scene>> = null;

          

          private _buildPipeline() {

              if (!this._buildAllowed) {

                  return;

              }

              this._scene.autoClear = true;

          

              const engine = this._scene.getEngine();

          

              this._disposePostProcesses();

              if (this._cameras !== null) {

                  this._scene.postProcessRenderPipelineManager.detachCamerasFromRenderPipeline(this._name, this._cameras);

                  // get back cameras to be used to reattach pipeline

                  this._cameras = this._camerasToBeAttached.slice();

              }

              this._reset();

              this._prevPostProcess = null;

              this._prevPrevPostProcess = null;

              this._hasCleared = false;

Is this necessary?

Cedric · May 27, 2024, 7:31am

cc @sebavan

Evgeni_Popov · May 27, 2024, 8:29am

It should not be a problem, as you probably don’t modify the pipeline each frame continuously? Also, not all parameters triggers a rebuild of the pipeline.

Topic		Replies	Views
Disabling and enabling a PostProcessRenderPipeline Questions	3	390	January 17, 2022
RenderingPipeline: how do you check if camera was already added to it? Questions documentation	1	589	October 17, 2019
Additional postprocessing with Pipeline Questions	9	1105	March 31, 2021
Default rendering Pipeline and multiple cameras Bugs	6	853	May 10, 2019
Toggle DefaultRenderingPipeline Questions	1	343	June 23, 2020

defaultRenderingPipeline Performance concerns

Related topics